| Message ID | 1345325159-7365-4-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 08/19/2012 12:25 AM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > The result of one call to a function is tested, and then at the second call > to the same function, the previous result, and not the current result, is > tested again. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression ret; > identifier f; > statement S1,S2; > @@ > > *ret = f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 > ... when any > *f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Thanks, but this was already fixed in ath6kl.git by this commit: commit 3206209f231062170f060fdbae38faacff86ddbf Author: Pandiyarajan Pitchaimuthu <c_ppitch@qca.qualcomm.com> Date: Wed Jul 11 12:51:43 2012 +0530 ath6kl: Make use of return value from ath6kl_diag_read() In ath6kl_read_fwlogs(), return value from ath6kl_diag_read()is not used to bail out in case of any errors in reading fw log. No real issue is observed because of this, reported by source code analyzer. kvalo: fix a long line warning Signed-off-by: Pandiyarajan Pitchaimuthu <c_ppitch@qca.qualcomm.com> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c index c189e28..c312c61 100644 --- a/drivers/net/wireless/ath/ath6kl/main.c +++ b/drivers/net/wireless/ath/ath6kl/main.c @@ -322,7 +322,8 @@ int ath6kl_read_fwlogs(struct ath6kl *ar) address = TARG_VTOP(ar->target_type, le32_to_cpu(debug_buf.next)); - ath6kl_diag_read(ar, address, &debug_buf, sizeof(debug_buf)); + ret = ath6kl_diag_read(ar, address, &debug_buf, + sizeof(debug_buf)); if (ret) goto out;