| Message ID | 1374546675-384-1-git-send-email-linville@tuxdriver.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 07/23/2013 04:31 AM, John W. Linville wrote: > From: "John W. Linville" <linville@tuxdriver.com> > > Otherwise, 'make allyesconfig' generates this: > > CC [M] drivers/net/ethernet/broadcom/bgmac.o > drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: > bcm47xx_nvram.h: No such file or directory > compilation terminated. > make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1 > make[3]: *** [drivers/net/ethernet/broadcom] Error 2 > make[2]: *** [drivers/net/ethernet] Error 2 > make[1]: *** [drivers/net] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: John W. Linville <linville@tuxdriver.com> > --- > drivers/bcma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig > index 7c081b3..a2bdab1 100644 > --- a/drivers/bcma/Kconfig > +++ b/drivers/bcma/Kconfig > @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE > > config BCMA_HOST_SOC > bool "Support for BCMA in a SoC" > - depends on BCMA > + depends on BCMA && BCM47XX > help > Host interface for a Broadcom AIX bus directly mapped into > the memory. This only works with the Broadcom SoCs from the > I think bgmac should depend on BCM47XX. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2013/7/23 Hauke Mehrtens <hauke@hauke-m.de>: > On 07/23/2013 04:31 AM, John W. Linville wrote: >> From: "John W. Linville" <linville@tuxdriver.com> >> >> Otherwise, 'make allyesconfig' generates this: >> >> CC [M] drivers/net/ethernet/broadcom/bgmac.o >> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: >> bcm47xx_nvram.h: No such file or directory >> compilation terminated. >> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1 >> make[3]: *** [drivers/net/ethernet/broadcom] Error 2 >> make[2]: *** [drivers/net/ethernet] Error 2 >> make[1]: *** [drivers/net] Error 2 >> make: *** [drivers] Error 2 >> >> Signed-off-by: John W. Linville <linville@tuxdriver.com> >> --- >> drivers/bcma/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >> index 7c081b3..a2bdab1 100644 >> --- a/drivers/bcma/Kconfig >> +++ b/drivers/bcma/Kconfig >> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE >> >> config BCMA_HOST_SOC >> bool "Support for BCMA in a SoC" >> - depends on BCMA >> + depends on BCMA && BCM47XX >> help >> Host interface for a Broadcom AIX bus directly mapped into >> the memory. This only works with the Broadcom SoCs from the >> > I think bgmac should depend on BCM47XX. Yeah, I'm wondering about that. It's bgmac that calls BCM47XX specific functions (nvram). On the other hand it doesn't make much sense to use BCMA_HOST_SOC on anything else than BCM47XX, does it?
2013/7/23 Rafa? Mi?ecki <zajec5@gmail.com>: > 2013/7/23 Hauke Mehrtens <hauke@hauke-m.de>: >> On 07/23/2013 04:31 AM, John W. Linville wrote: >>> From: "John W. Linville" <linville@tuxdriver.com> >>> >>> Otherwise, 'make allyesconfig' generates this: >>> >>> CC [M] drivers/net/ethernet/broadcom/bgmac.o >>> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: >>> bcm47xx_nvram.h: No such file or directory >>> compilation terminated. >>> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1 >>> make[3]: *** [drivers/net/ethernet/broadcom] Error 2 >>> make[2]: *** [drivers/net/ethernet] Error 2 >>> make[1]: *** [drivers/net] Error 2 >>> make: *** [drivers] Error 2 >>> >>> Signed-off-by: John W. Linville <linville@tuxdriver.com> >>> --- >>> drivers/bcma/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >>> index 7c081b3..a2bdab1 100644 >>> --- a/drivers/bcma/Kconfig >>> +++ b/drivers/bcma/Kconfig >>> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE >>> >>> config BCMA_HOST_SOC >>> bool "Support for BCMA in a SoC" >>> - depends on BCMA >>> + depends on BCMA && BCM47XX >>> help >>> Host interface for a Broadcom AIX bus directly mapped into >>> the memory. This only works with the Broadcom SoCs from the >>> >> I think bgmac should depend on BCM47XX. > > Yeah, I'm wondering about that. > > It's bgmac that calls BCM47XX specific functions (nvram). And this is bad, make that a platform_data callback or something like that such that there is no build-time dependency on nvram functions. > > On the other hand it doesn't make much sense to use BCMA_HOST_SOC on > anything else than BCM47XX, does it? Hauke has been working on BCM53XX which is an ARM-based BCM47XX-like SoC, but that just means depends on (BCM47XX || ARCH_BCM53XX) then. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/23/2013 01:06 PM, Florian Fainelli wrote: > 2013/7/23 Rafa? Mi?ecki <zajec5@gmail.com>: >> 2013/7/23 Hauke Mehrtens <hauke@hauke-m.de>: >>> On 07/23/2013 04:31 AM, John W. Linville wrote: >>>> From: "John W. Linville" <linville@tuxdriver.com> >>>> >>>> Otherwise, 'make allyesconfig' generates this: >>>> >>>> CC [M] drivers/net/ethernet/broadcom/bgmac.o >>>> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: >>>> bcm47xx_nvram.h: No such file or directory >>>> compilation terminated. >>>> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1 >>>> make[3]: *** [drivers/net/ethernet/broadcom] Error 2 >>>> make[2]: *** [drivers/net/ethernet] Error 2 >>>> make[1]: *** [drivers/net] Error 2 >>>> make: *** [drivers] Error 2 >>>> >>>> Signed-off-by: John W. Linville <linville@tuxdriver.com> >>>> --- >>>> drivers/bcma/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >>>> index 7c081b3..a2bdab1 100644 >>>> --- a/drivers/bcma/Kconfig >>>> +++ b/drivers/bcma/Kconfig >>>> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE >>>> >>>> config BCMA_HOST_SOC >>>> bool "Support for BCMA in a SoC" >>>> - depends on BCMA >>>> + depends on BCMA && BCM47XX >>>> help >>>> Host interface for a Broadcom AIX bus directly mapped into >>>> the memory. This only works with the Broadcom SoCs from the >>>> >>> I think bgmac should depend on BCM47XX. >> >> Yeah, I'm wondering about that. >> >> It's bgmac that calls BCM47XX specific functions (nvram). > > And this is bad, make that a platform_data callback or something like > that such that there is no build-time dependency on nvram functions. Ok, I will try that. I still have no idea how to handle the nvram stuff properly with DT on arm. My current plan is to do this stuff properly for arm and try to use most of the improvements also for mips. >> On the other hand it doesn't make much sense to use BCMA_HOST_SOC on >> anything else than BCM47XX, does it? > > Hauke has been working on BCM53XX which is an ARM-based BCM47XX-like > SoC, but that just means depends on (BCM47XX || ARCH_BCM53XX) then. Yes preparing for adding arm support was the intention of this patch series, it was some code which should not harm the mips part or any other. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig index 7c081b3..a2bdab1 100644 --- a/drivers/bcma/Kconfig +++ b/drivers/bcma/Kconfig @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE config BCMA_HOST_SOC bool "Support for BCMA in a SoC" - depends on BCMA + depends on BCMA && BCM47XX help Host interface for a Broadcom AIX bus directly mapped into the memory. This only works with the Broadcom SoCs from the