From patchwork Mon Oct 14 11:16:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Markowski X-Patchwork-Id: 3035721 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 340729F2B7 for ; Mon, 14 Oct 2013 11:16:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0EF2D2021F for ; Mon, 14 Oct 2013 11:16:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07A0B20131 for ; Mon, 14 Oct 2013 11:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756012Ab3JNLQe (ORCPT ); Mon, 14 Oct 2013 07:16:34 -0400 Received: from ebb05.tieto.com ([131.207.168.36]:65490 "EHLO ebb05.tieto.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755934Ab3JNLQd (ORCPT ); Mon, 14 Oct 2013 07:16:33 -0400 X-AuditID: 83cfa824-b7f668e000004d8e-15-525bd28f39c9 Received: from FIVLA-EXHUB02.eu.tieto.com ( [131.207.136.42]) by ebb05.tieto.com (SMTP Mailer) with SMTP id 50.C2.19854.F82DB525; Mon, 14 Oct 2013 14:16:31 +0300 (EEST) Received: from uw000975.eu.tieto.com (10.28.19.100) by inbound.tieto.com (131.207.136.49) with Microsoft SMTP Server id 8.3.298.1; Mon, 14 Oct 2013 14:16:31 +0300 From: Bartosz Markowski To: CC: , Bartosz Markowski Subject: [PATCH] ath10k: do not warn about unsupported vdev param Date: Mon, 14 Oct 2013 13:16:21 +0200 Message-ID: <1381749381-15459-1-git-send-email-bartosz.markowski@tieto.com> X-Mailer: git-send-email 1.7.10 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsXSfL5DS7f/UnSQweY9VhaPLh1jtngy+TuL xZsVd9gdmD0+z7zL5rF5Sb3H501yAcxRXDYpqTmZZalF+nYJXBlH23tZCn6zV5x5uYKlgfEx WxcjJ4eEgInE9IvvWCFsMYkL99YDxbk4hARWMUq8mtAE5SxjlNi6/hIjSBWbgKnE/Q0rwDpE BBQkfk36CDaJWSBc4tXWXywgtrCAo8TleTfBbBYBVYl/F56xg9i8At4Si7uXMkFsk5d4er+P DSIuKHFy5hMWiDkSEgdfvGAGsYUENCTm7HzJMoGRbxaSsllIyhYwMq1i5E9NSjIw1SvJTC3J 10vOz93ECA6qFSo7GM8+kDrEKMDBqMTDK+AUHSTEmlhWXJl7iFGSg0lJlJfpAlCILyk/pTIj sTgjvqg0J7X4EKMEB7OSCG/7CaAcb0piZVVqUT5MSpqDRUmc98K1oCAhgfTEktTs1NSC1CKY rAwHh5IEL8dFoEbBotT01Iq0zJwShDQTByfIcB6g4c4gNbzFBYm5xZnpEPlTjIpS4ryyIAkB kERGaR5cLyzqXzGKA70izOsKUsUDTBhw3a+ABjMBDf75NgJkcEkiQkqqgbFHRMHlbFTQ4jCG yJmrfyU8Zu63Wyhzrc/iyQEl0dSHqdY3JrfESZ1sO3/1/eppEqdWip6ZaHZ8xZQP9h2OjKmc k9WfWdRJPd109/zD4h9sbQsDbVprzGRytstHpX5iWBNzb/fJF4f13SZ2pzsLSK0MO2sZMctb dXrKu6Xnyiujdv506omfHKLEUpyRaKjFXFScCAAnt+D71QIAAA== Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 10.X firmware does not support WMI_VDEV_PARAM_TX_ENCAP_TYPE. It's a known limitation and we should not warn about this. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 049eca2..9c800f8 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2085,7 +2085,9 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, vdev_param = ar->wmi.vdev_param->tx_encap_type; ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, ATH10K_HW_TXRX_NATIVE_WIFI); - if (ret) + + /* 10.X firmware does not support this VDEV parameter. Do not warn */ + if (ret && !test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) ath10k_warn("Failed to set TX encap: %d\n", ret); if (arvif->vdev_type == WMI_VDEV_TYPE_AP) {