From patchwork Tue Oct 15 07:26:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Markowski X-Patchwork-Id: 3043681 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 710E29F2B6 for ; Tue, 15 Oct 2013 07:26:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 56A64200F2 for ; Tue, 15 Oct 2013 07:26:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B86C200ED for ; Tue, 15 Oct 2013 07:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753968Ab3JOH02 (ORCPT ); Tue, 15 Oct 2013 03:26:28 -0400 Received: from ebb06.tieto.com ([131.207.168.38]:63853 "EHLO ebb06.tieto.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669Ab3JOH02 (ORCPT ); Tue, 15 Oct 2013 03:26:28 -0400 X-AuditID: 83cfa826-b7f628e000004b87-db-525cee221900 Received: from FIVLA-EXHUB02.eu.tieto.com ( [131.207.136.42]) by ebb06.tieto.com (SMTP Mailer) with SMTP id 87.E1.19335.22EEC525; Tue, 15 Oct 2013 10:26:26 +0300 (EEST) Received: from uw000975.eu.tieto.com (10.28.19.100) by inbound.tieto.com (131.207.136.49) with Microsoft SMTP Server id 8.3.298.1; Tue, 15 Oct 2013 10:26:24 +0300 From: Bartosz Markowski To: CC: , Bartosz Markowski Subject: [PATCH v2] ath10k: do not warn about unsupported vdev param Date: Tue, 15 Oct 2013 09:26:20 +0200 Message-ID: <1381821980-7966-1-git-send-email-bartosz.markowski@tieto.com> X-Mailer: git-send-email 1.7.10 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsXSfL5DS1fpXUyQwZuNAhaPLh1jtngy+TuL xZsVd9gdmD0+z7zL5rF5Sb3H501yAcxRXDYpqTmZZalF+nYJXBlXHmxgL/jNXfHl+0P2BsYe ri5GTg4JAROJHfPvs0PYYhIX7q1n62Lk4hASWMUocWPrflYIZxmjxJWr9xhBqtgETCXub1jB CmKLCChI/Jr0kQ3EZhYIl3i19RcLiC0s4CJx/9wRsHoWAVWJzWs3g8V5BbwkDk/YxgaxTV7i 6f0+Noi4oMTJmU9YIOZISBx88YIZxBYS0JCYs/MlywRGvllIymYhKVvAyLSKkT81KcnATK8k M7UkXy85P3cTIzioVqjtYHz2QOoQowAHoxIPL4NoTJAQa2JZcWXuIUZJDiYlUd4Fr4FCfEn5 KZUZicUZ8UWlOanFhxglOJiVRHi/3wfK8aYkVlalFuXDpKQ5WJTEee8+jQ4SEkhPLEnNTk0t SC2CycpwcChJ8N58A9QoWJSanlqRlplTgpBm4uAEGc4DNPwNSA1vcUFibnFmOkT+FKOilDjv S5CEAEgiozQPrhcW9a8YxYFeEeY1eQtUxQNMGHDdr4AGMwEN/nYbbHBJIkJKqoExjGNhifn0 Ffvr29wXLA18vLLj4tT+wtkvSzt2nQt2s/ypdODyFDexh0fWGSfMKNSe9qHF/ZNY03yWuw9L J35/tSv43LG5rHk35s+IvsFxbMe2nJNOjp9nr1ru/zGo/dhCbZXrUdyfG278MK9Z9NxfrG/N z93Pt4X+KC6YXfPVbq5i833T/jvHRZVYijMSDbWYi4oTATBkB/3VAgAA Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 10.X firmware does not support WMI_VDEV_PARAM_TX_ENCAP_TYPE. It's a known limitation and we should not warn about this. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/mac.c | 3 ++- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 049eca2..97d7111 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2085,7 +2085,8 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, vdev_param = ar->wmi.vdev_param->tx_encap_type; ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, ATH10K_HW_TXRX_NATIVE_WIFI); - if (ret) + /* 10.X firmware does not support this VDEV parameter. Do not warn */ + if (ret && ret != -EOPNOTSUPP) ath10k_warn("Failed to set TX encap: %d\n", ret); if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index f9766fa..fa07388 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2763,7 +2763,7 @@ int ath10k_wmi_vdev_set_param(struct ath10k *ar, u32 vdev_id, ath10k_dbg(ATH10K_DBG_WMI, "vdev param %d not supported by firmware\n", param_id); - return -EINVAL; + return -EOPNOTSUPP; } skb = ath10k_wmi_alloc_skb(sizeof(*cmd));