| Message ID | 1389681497-18267-1-git-send-email-bartosz.markowski@tieto.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Bartosz Markowski <bartosz.markowski@tieto.com> writes: > chandef does not provide 11n / 11ac split. Use the highest > phymodes for 20/40MHz channels, firmware can operate on. > > Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> Is this just code cleanup and or does this actually fix something? > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -256,10 +256,10 @@ chan_to_phymode(const struct cfg80211_chan_def *chandef) > phymode = MODE_11A; > break; > case NL80211_CHAN_WIDTH_20: > - phymode = MODE_11NA_HT20; > + phymode = MODE_11AC_VHT20; > break; > case NL80211_CHAN_WIDTH_40: > - phymode = MODE_11NA_HT40; > + phymode = MODE_11AC_VHT40; > break; > case NL80211_CHAN_WIDTH_80: > phymode = MODE_11AC_VHT80; But doesn't this mean that we will use, for example, MODE_11AC_VHT20 on 11n mode? I think we need to investigate how MODE_11AC_VHT20 and MODE_11NA_HT20 actually differ (and the same for 40 MHz channels).
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 7aa6c4d..e0b1a2a 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -256,10 +256,10 @@ chan_to_phymode(const struct cfg80211_chan_def *chandef) phymode = MODE_11A; break; case NL80211_CHAN_WIDTH_20: - phymode = MODE_11NA_HT20; + phymode = MODE_11AC_VHT20; break; case NL80211_CHAN_WIDTH_40: - phymode = MODE_11NA_HT40; + phymode = MODE_11AC_VHT40; break; case NL80211_CHAN_WIDTH_80: phymode = MODE_11AC_VHT80;
chandef does not provide 11n / 11ac split. Use the highest phymodes for 20/40MHz channels, firmware can operate on. Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> --- drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)