From patchwork Fri Mar 28 17:12:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Merello X-Patchwork-Id: 3905301 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EB81BBF540 for ; Fri, 28 Mar 2014 17:11:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 28FA0202FE for ; Fri, 28 Mar 2014 17:11:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAC2E20108 for ; Fri, 28 Mar 2014 17:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbaC1RK6 (ORCPT ); Fri, 28 Mar 2014 13:10:58 -0400 Received: from mail-ee0-f52.google.com ([74.125.83.52]:61485 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819AbaC1RK5 (ORCPT ); Fri, 28 Mar 2014 13:10:57 -0400 Received: by mail-ee0-f52.google.com with SMTP id e49so4314565eek.11 for ; Fri, 28 Mar 2014 10:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xVA+tSVndq5Rp89Yl/IsCicdePXNZU6s5S/pODgrGck=; b=j9NDuC6lP/oFOxIps9y7jqXTu7TT16lZmKmt5M4M2OdF27AhzbFRpfO6urLQ8kdvU4 spn+NuZ6wpVg3FES95aKURbz4OCZpq6AN7gmDQLmOdJzgHNpyLr70eNMbwlGFAXshYmq t+O9A0+/LtMx0I2h4Sfp6L47TLcieyn6YhbIvw9NW+QwJ7gqV2ey1acV0M8cvZFrNkiT SbSCJEWa30EoI2hjABcztt7DI6QdgRlXuOShNND6po6jkgqmPB0vw1hnQXPXVt0q7r9r d09A6L79QGk20cUi2mrFVcIHoPel7MDUwOcKuuahq4F7vhIF44+plGRz319plm32YlJV OAgA== X-Received: by 10.14.213.6 with SMTP id z6mr464357eeo.98.1396026656043; Fri, 28 Mar 2014 10:10:56 -0700 (PDT) Received: from localhost.localdomain (host179-124-dynamic.6-79-r.retail.telecomitalia.it. [79.6.124.179]) by mx.google.com with ESMTPSA id o7sm12837278eew.25.2014.03.28.10.10.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Mar 2014 10:10:55 -0700 (PDT) From: Andrea Merello To: fengguang.wu@intel.com, linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, andrea.merello@gmail.com Subject: [PATCH 1/2] rtl8187: fix compile warning Date: Fri, 28 Mar 2014 18:12:08 +0100 Message-Id: <1396026728-5569-1-git-send-email-andrea.merello@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <5334b1ac.IdF9Kz2kTwX26Omj%fengguang.wu@intel.com> References: <5334b1ac.IdF9Kz2kTwX26Omj%fengguang.wu@intel.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ANAPARAM3 register, defined in the rtl818x common register struct, is accessed as 16bit by rtl8187se and as 8bit by rtl8187b. Since I have no documentation about this, I can only stick to the reference code and to what is known to work. This issue has been addressed by a patch from Larry Finger that introduces an "union", in the register struct. In my last patch-set I applied it on the register struct, but I forget to update rtl8187 driver too. This patch does it. Suggested-by: Larry Finger [ Original patch ] Signed-off-by: Andrea Merello --- drivers/net/wireless/rtl818x/rtl8187/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rtl818x/rtl8187/dev.c b/drivers/net/wireless/rtl818x/rtl8187/dev.c index c981bcf..2c79bcc 100644 --- a/drivers/net/wireless/rtl818x/rtl8187/dev.c +++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c @@ -592,7 +592,7 @@ static void rtl8187_set_anaparam(struct rtl8187_priv *priv, bool rfon) rtl818x_iowrite32(priv, &priv->map->ANAPARAM, anaparam); rtl818x_iowrite32(priv, &priv->map->ANAPARAM2, anaparam2); if (priv->is_rtl8187b) - rtl818x_iowrite8(priv, &priv->map->ANAPARAM3, anaparam3); + rtl818x_iowrite8(priv, &priv->map->ANAPARAM3A, anaparam3); reg &= ~RTL818X_CONFIG3_ANAPARAM_WRITE; rtl818x_iowrite8(priv, &priv->map->CONFIG3, reg); rtl818x_iowrite8(priv, &priv->map->EEPROM_CMD,