| Message ID | 1397544101-18135-5-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, Apr 15, 2014 at 02:41:38PM +0800, Chen-Yu Tsai wrote: > rfkill-gpio has clk_enabled = blocked, which is true when rfkill > blocks the device. This results in calling clock enable/disable at > the wrong time. Reversing the value fixes this. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index 29ff07c..f46ddf7 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -57,7 +57,7 @@ static int rfkill_gpio_set_power(void *data, bool blocked) gpiod_set_value(rfkill->shutdown_gpio, 1); } - rfkill->clk_enabled = blocked; + rfkill->clk_enabled = !blocked; return 0; }
rfkill-gpio has clk_enabled = blocked, which is true when rfkill blocks the device. This results in calling clock enable/disable at the wrong time. Reversing the value fixes this. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- net/rfkill/rfkill-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)