From patchwork Wed May 14 11:57:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Markowski X-Patchwork-Id: 4174361 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BF2A5BFF02 for ; Wed, 14 May 2014 11:57:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 047C020212 for ; Wed, 14 May 2014 11:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 257B32020E for ; Wed, 14 May 2014 11:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbaENL5T (ORCPT ); Wed, 14 May 2014 07:57:19 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:40478 "EHLO mail-ee0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbaENL5S (ORCPT ); Wed, 14 May 2014 07:57:18 -0400 Received: by mail-ee0-f48.google.com with SMTP id e49so1286349eek.21 for ; Wed, 14 May 2014 04:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=4lbpNAhrHGRkFiq++aW8yF7SwjRLVBBP5pEI+Jsl9YA=; b=bugJY0QrJf3LMWnB+ijAaNeuKRp/l7kMUAdiJe+AeSSgOp7ObCOCv0JNS+W3y+NwV9 PZKQR3H3jbq0dp+OCe4VOkGTVfHti1S/boSd/V3fVioRwSjanrqDW9+m2HEcqZBMBmWR 6nCg3j0DMwIrqhGmHACxLpP7q+DPwNFxg6LTE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4lbpNAhrHGRkFiq++aW8yF7SwjRLVBBP5pEI+Jsl9YA=; b=jvm1uBeMsqI2sKtyRXgn25bL1z20+rXNggeeKTzBBSx25uwbPnBXifp+j0KQEthH/+ H7Z/IPHsB87ab7FLOTQWQWffnSVpICSX3y7/Ly42uCrkkZDn7f4UXPAn4aztQUJYuhrB 7wIQ9fd8FTnPjebQ71i5Jo/yQMuFKHms5NbXkqJBaBQ1BbWP8soC2jy3IxyBUCcoxYnB X/L224KpAv8AOZeB2WvsgVybMaE6tynF+YPsQPbn2AdV0lQNO7MBTsiYzXJNpCKo4N6y QPqNsVqwRgFSgu93m8vjgs573vVBuhJcA6NryvgcHloW9Ob4cMHR1XlDALhiTVhX1SJ5 4TIw== X-Gm-Message-State: ALoCoQkgfChxOoBEKEkNdxUQM4fQg1q9pb+bQ2W6ezLLqdsZAP9MFWYt0Ab3qs5czh98iCWXx/dKAmHfAm2xiZZH8/74P2XSXbHU7fOJczkwcxLFzRBZgAE= X-Received: by 10.15.67.142 with SMTP id u14mr5191537eex.19.1400068637143; Wed, 14 May 2014 04:57:17 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id o7sm4599961eew.25.2014.05.14.04.57.15 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 May 2014 04:57:16 -0700 (PDT) From: Bartosz Markowski To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Bartosz Markowski Subject: [PATCH] ath10k: get rid of pci_assign_resource() call from pci_probe Date: Wed, 14 May 2014 13:57:07 +0200 Message-Id: <1400068627-4076-1-git-send-email-bartosz.markowski@tieto.com> X-Mailer: git-send-email 1.8.2 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On ARM-based (MSM mach), the pci_assign_resource() is passing some invalid pointers and leading to L2 cache errors, what prevents the PCI communication completly. So far I have not found this funtion to be directly called by any other wifi driver and did not found this assigning needed on any other platform. So removing it completly. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/pci.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 66b1f30..9a579cd 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2602,18 +2602,6 @@ static int ath10k_pci_probe(struct pci_dev *pdev, pci_set_drvdata(pdev, ar); - /* - * Without any knowledge of the Host, the Target may have been reset or - * power cycled and its Config Space may no longer reflect the PCI - * address space that was assigned earlier by the PCI infrastructure. - * Refresh it now. - */ - ret = pci_assign_resource(pdev, BAR_NUM); - if (ret) { - ath10k_err("failed to assign PCI space: %d\n", ret); - goto err_ar; - } - ret = pci_enable_device(pdev); if (ret) { ath10k_err("failed to enable PCI device: %d\n", ret);