From patchwork Sun Jun 8 01:41:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4316631 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BF4FFBEEAA for ; Sun, 8 Jun 2014 01:40:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F0BD120274 for ; Sun, 8 Jun 2014 01:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08FCB20270 for ; Sun, 8 Jun 2014 01:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753437AbaFHBkP (ORCPT ); Sat, 7 Jun 2014 21:40:15 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:61195 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbaFHBkO (ORCPT ); Sat, 7 Jun 2014 21:40:14 -0400 Received: by mail-wg0-f44.google.com with SMTP id x13so1613325wgg.3 for ; Sat, 07 Jun 2014 18:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=W0toCHET5JiHSvTtJm4VnjxTMkfVmQwwg3fpk5jsjDs=; b=fQaQZrvSTf/BEdRHamgJF9K88Nmn5JIL1bCMcs45UFpqE4x7urfmrvT52IsYZF2Q7o JManW+pgCUTAlzzoOMB3cLSeD8MN5NzKbhyS/QY+y0pDnhwMsPR3d6jbV/V766rwyiet VkvNYbnULfQONsqX8oYE8mFC0CSU+P7Hy/Nd7bacmCVMkq0lgjttDs+yRo8LGVVamiBC MkYYr2gp2cF1/ccf3VxaOiMplX+xy5PQPIB7liijXxJxMRoTnqa/W0Dx/Ns1LsPEoBe3 KwXvYugccYetkgXU9pGnefeXCeB6Iovak5VoNXNJsLbrtpOTU+AE95gdTz+tXxcb79Vz BQ0g== X-Gm-Message-State: ALoCoQnsWAbE2zA/IXcs0b8tDg1HbNkQnDCuLtGyaUs/wbQp09GySg0/dxZ86iP1G+2XgM+SMWeW X-Received: by 10.14.194.136 with SMTP id m8mr799763een.4.1402191613413; Sat, 07 Jun 2014 18:40:13 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id f45sm13288644eem.15.2014.06.07.18.40.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jun 2014 18:40:09 -0700 (PDT) From: Rickard Strandqvist To: Larry Finger , Chaoming Li Cc: Rickard Strandqvist , "John W. Linville" , Joe Perches , Peter Wu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: wireless: rtlwifi: rtl8723ae: hw.c: Cleaning up if statement that always evaluates to false Date: Sun, 8 Jun 2014 03:41:05 +0200 Message-Id: <1402191665-26089-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false After pointing this out, Larry Finger informed what would be the correct one. '(X & 0x3) == 0x3' Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/rtlwifi/rtl8723ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c index 65c9e80..6703f36 100644 --- a/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c @@ -1109,7 +1109,7 @@ static int _rtl8723ae_set_media_status(struct ieee80211_hw *hw, rtl_write_byte(rtlpriv, (MSR), bt_msr); rtlpriv->cfg->ops->led_control(hw, ledaction); - if ((bt_msr & 0x03) == MSR_AP) + if ((bt_msr & MSR_AP) == MSR_AP) rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00); else rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);