From patchwork Sun Dec 21 00:37:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5523591 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D840F9F30B for ; Sun, 21 Dec 2014 00:34:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 14A7A2016C for ; Sun, 21 Dec 2014 00:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30D9B20166 for ; Sun, 21 Dec 2014 00:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbaLUAek (ORCPT ); Sat, 20 Dec 2014 19:34:40 -0500 Received: from mail-wg0-f54.google.com ([74.125.82.54]:42994 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753058AbaLUAei (ORCPT ); Sat, 20 Dec 2014 19:34:38 -0500 Received: by mail-wg0-f54.google.com with SMTP id l2so4138722wgh.13 for ; Sat, 20 Dec 2014 16:34:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IzQ3s1fitDblYEPU4yW5gYCu8SaTC8IbdeWCnSCUUzU=; b=MHtKPGmdN9OYXZG8sf1Qg9T9yO2NiYx7/9IynfRvk+wE0HFZ0mqM2yPXgGHDusLHJp JJOdZ4cYyUwdN0I7LvgT33AxGr7nQdRMuxoGrNLq2RTl6ii0QKhebMM5gzS+Q0Csa7Ce U8z6Ja7nXmFVVwhPoStSS0WyXOT5BQXQ6rDr8ARGMy8+dTfY7G2k4Ieobbha5o9Y5zog TUuHVfoQ/mIRz0hA26kDgbrJcrxQvgewU+eeiGKW26XaR4oWYT66ZtdHmM09s1skc2We DzpD5hMyeYzTnej7prj8ZWeIMK6rO+AVcT/m50B89wx2Eq82WK4krc83BxIUbOuA8I+y VVgw== X-Gm-Message-State: ALoCoQmlYXpa7hnmcaQwz8kGqRGhoMM8NJNVYKj/7MtZT3HeBod1M5SmVcPbCaYYb9oHv0/Ja2+z X-Received: by 10.180.83.129 with SMTP id q1mr18486094wiy.8.1419122077198; Sat, 20 Dec 2014 16:34:37 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id h8sm7604748wiy.17.2014.12.20.16.34.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Dec 2014 16:34:36 -0800 (PST) From: Rickard Strandqvist To: Brett Rudley , Arend van Spriel Cc: Rickard Strandqvist , Hante Meuleman , Kalle Valo , Fabian Frederick , "David S. Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: wireless: brcm80211: brcmsmac: phy: phy_n.c: Remove unused function Date: Sun, 21 Dec 2014 01:37:24 +0100 Message-Id: <1419122244-14765-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function wlc_phy_txpwr_idx_get_nphy() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- .../net/wireless/brcm80211/brcmsmac/phy/phy_int.h | 1 - drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h index 4960f7d..c3d4f17 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_int.h @@ -1104,7 +1104,6 @@ void wlc_phy_txpwrctrl_enable_nphy(struct brcms_phy *pi, u8 ctrl_type); void wlc_phy_txpwr_fixpower_nphy(struct brcms_phy *pi); void wlc_phy_txpwr_apply_nphy(struct brcms_phy *pi); void wlc_phy_txpwr_papd_cal_nphy(struct brcms_phy *pi); -u16 wlc_phy_txpwr_idx_get_nphy(struct brcms_phy *pi); struct nphy_txgains wlc_phy_get_tx_gain_nphy(struct brcms_phy *pi); int wlc_phy_cal_txiqlo_nphy(struct brcms_phy *pi, diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c index 084f18f..44cb2f0 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c @@ -28257,25 +28257,6 @@ static bool wlc_phy_txpwr_ison_nphy(struct brcms_phy *pi) (0x1 << 14) | (0x1 << 13)); } -u16 wlc_phy_txpwr_idx_get_nphy(struct brcms_phy *pi) -{ - u16 tmp; - u16 pwr_idx[2]; - - if (wlc_phy_txpwr_ison_nphy(pi)) { - pwr_idx[0] = wlc_phy_txpwr_idx_cur_get_nphy(pi, PHY_CORE_0); - pwr_idx[1] = wlc_phy_txpwr_idx_cur_get_nphy(pi, PHY_CORE_1); - - tmp = (pwr_idx[0] << 8) | pwr_idx[1]; - } else { - tmp = ((pi->nphy_txpwrindex[PHY_CORE_0].index_internal & 0xff) - << 8) | - (pi->nphy_txpwrindex[PHY_CORE_1].index_internal & 0xff); - } - - return tmp; -} - void wlc_phy_txpwr_papd_cal_nphy(struct brcms_phy *pi) { if (PHY_IPA(pi)