From patchwork Mon Dec 22 18:10:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 5528681 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 736CD9F1CD for ; Mon, 22 Dec 2014 18:10:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7F0172018E for ; Mon, 22 Dec 2014 18:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DE062017A for ; Mon, 22 Dec 2014 18:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755541AbaLVSKV (ORCPT ); Mon, 22 Dec 2014 13:10:21 -0500 Received: from cpsmtpb-ews01.kpnxchange.com ([213.75.39.4]:62532 "EHLO cpsmtpb-ews01.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754957AbaLVSKU (ORCPT ); Mon, 22 Dec 2014 13:10:20 -0500 Received: from cpsps-ews15.kpnxchange.com ([10.94.84.182]) by cpsmtpb-ews01.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 22 Dec 2014 19:10:18 +0100 Received: from CPSMTPM-TLF101.kpnxchange.com ([195.121.3.4]) by cpsps-ews15.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 22 Dec 2014 19:10:18 +0100 Received: from x41 ([77.173.140.92]) by CPSMTPM-TLF101.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 22 Dec 2014 19:10:17 +0100 Message-ID: <1419271817.2317.12.camel@tiscali.nl> Subject: [PATCH RFC] ipw2200: select CFG80211_WEXT From: Paul Bolle To: Johannes Berg Cc: Stanislav Yakovlev , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 22 Dec 2014 19:10:17 +0100 X-Mailer: Evolution 3.12.8 (3.12.8-1.fc21) Mime-Version: 1.0 X-OriginalArrivalTime: 22 Dec 2014 18:10:17.0843 (UTC) FILETIME=[8AAAAC30:01D01E12] X-RcptDomain: vger.kernel.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. Signed-off-by: Paul Bolle --- Johannes, Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again. (A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.) I must admit that I do not fully understand your commit. (How was CFG80211_WEXT "marked for deprecation and removal for a little more than two years"?) There's some terminology confusion: what you call "select" I tend to call "set". Anyhow, your commit basically disables building ipw2200 (and apparently orinoco and friends)? Was that your intention? drivers/net/wireless/ipw2x00/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ipw2x00/Kconfig b/drivers/net/wireless/ipw2x00/Kconfig index 91c0cb3c368e..21de4fe6cf2d 100644 --- a/drivers/net/wireless/ipw2x00/Kconfig +++ b/drivers/net/wireless/ipw2x00/Kconfig @@ -65,7 +65,8 @@ config IPW2100_DEBUG config IPW2200 tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection" - depends on PCI && CFG80211 && CFG80211_WEXT + depends on PCI && CFG80211 + select CFG80211_WEXT select WIRELESS_EXT select WEXT_SPY select WEXT_PRIV