From patchwork Tue Dec 30 12:20:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 5552211 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0316CBFE6A for ; Tue, 30 Dec 2014 13:03:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 407402012E for ; Tue, 30 Dec 2014 13:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 627F320173 for ; Tue, 30 Dec 2014 13:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbaL3NDt (ORCPT ); Tue, 30 Dec 2014 08:03:49 -0500 Received: from www.osadl.org ([62.245.132.105]:51273 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbaL3NDs (ORCPT ); Tue, 30 Dec 2014 08:03:48 -0500 X-Greylist: delayed 2304 seconds by postgrey-1.27 at vger.kernel.org; Tue, 30 Dec 2014 08:03:42 EST Received: from debian.hofrr.at (92-243-35-153.adsl.nanet.at [92.243.35.153] (may be forged)) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id sBUCON1A021368; Tue, 30 Dec 2014 13:25:01 +0100 From: Nicholas Mc Guire To: Kalle Valo Cc: Michal Kazior , Ben Greear , Chun-Yeow Yeoh , Yanbo Li , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH 4/4] ath10k: fixup wait_for_completion_timeout return handling Date: Tue, 30 Dec 2014 07:20:46 -0500 Message-Id: <1419942046-17985-5-git-send-email-der.herr@hofr.at> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1419942046-17985-1-git-send-email-der.herr@hofr.at> References: <1419942046-17985-1-git-send-email-der.herr@hofr.at> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP wait_for_completion_timeout does not return negative values so "ret" handling here should check for timeout only. patch was only compile tested for x86_64_defconfig + CONFIG_ATH10K=m patch is against linux-next 3.19.0-rc1 -next-20141226 Signed-off-by: Nicholas Mc Guire --- drivers/net/wireless/ath/ath10k/htt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.c b/drivers/net/wireless/ath/ath10k/htt.c index 56cb4ac..58b6fc1 100644 --- a/drivers/net/wireless/ath/ath10k/htt.c +++ b/drivers/net/wireless/ath/ath10k/htt.c @@ -102,7 +102,7 @@ int ath10k_htt_setup(struct ath10k_htt *htt) status = wait_for_completion_timeout(&htt->target_version_received, HTT_TARGET_VERSION_TIMEOUT_HZ); - if (status <= 0) { + if (status == 0) { ath10k_warn(ar, "htt version request timed out\n"); return -ETIMEDOUT; }