From patchwork Sun Jan 4 15:43:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5564091 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 29BF99F6B5 for ; Sun, 4 Jan 2015 15:41:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 558EF201BC for ; Sun, 4 Jan 2015 15:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67D61201CD for ; Sun, 4 Jan 2015 15:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbbADPky (ORCPT ); Sun, 4 Jan 2015 10:40:54 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:42993 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648AbbADPkx (ORCPT ); Sun, 4 Jan 2015 10:40:53 -0500 Received: by mail-lb0-f169.google.com with SMTP id p9so16814461lbv.0 for ; Sun, 04 Jan 2015 07:40:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Rz8QkdfE0blaI5mENN1ytuph8g1pwsAHgXcpFeqy0ag=; b=LNqDGuh4I9QGYOEL6CCJu7kNPx2LAtLZNB5ZsBFrwueqm3RtG42WGqxFb29E8D6N++ ir7GPwprhRs15WTpVk90V6koM+/cZf2I4nmaMm4i1j7cqdZNfo+Y0LAEWAjdZpMUzZJs E99b7Z40BOFNBjBu8+ggflphPCwCuGQTqdt32wtjZKyKEhMxSUsxeYIxqGQxzzm1s7pb lncFgVf0K6Aa2FQuLn4eeAM009qKT0uslO81cKQAgQJu0lBTigw65fYsbAR64U9BbVGK YzdRn9DyxolFTn7CPx9qbTChZ6HJwe9G0shm/389cj1A2AmGMK0FPHXO1zLfT6rBQxb5 YC1g== X-Gm-Message-State: ALoCoQldfJBjrqYEcGVl5hZhCfmkzkVsuN3bQ+khPuzy6IyOJG1KnaY4C8SeycgwN0d0vkFz9BKf X-Received: by 10.152.25.129 with SMTP id c1mr81540881lag.65.1420386051143; Sun, 04 Jan 2015 07:40:51 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id i5sm11154996lae.26.2015.01.04.07.40.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2015 07:40:50 -0800 (PST) From: Rickard Strandqvist To: Kalle Valo , Pavel Machek Cc: Rickard Strandqvist , =?UTF-8?q?Pali=20Roh=C3=A1r?= , David Gnedt , George Spelvin , Surendra Patil , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wl1251: Remove unused function Date: Sun, 4 Jan 2015 16:43:52 +0100 Message-Id: <1420386232-12344-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function wl1251_cmd_read_memory() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/ti/wl1251/cmd.c | 40 ---------------------------------- drivers/net/wireless/ti/wl1251/cmd.h | 2 -- 2 files changed, 42 deletions(-) diff --git a/drivers/net/wireless/ti/wl1251/cmd.c b/drivers/net/wireless/ti/wl1251/cmd.c index ede31f0..26f4d74 100644 --- a/drivers/net/wireless/ti/wl1251/cmd.c +++ b/drivers/net/wireless/ti/wl1251/cmd.c @@ -346,46 +346,6 @@ out: return ret; } -int wl1251_cmd_read_memory(struct wl1251 *wl, u32 addr, void *answer, - size_t len) -{ - struct cmd_read_write_memory *cmd; - int ret = 0; - - wl1251_debug(DEBUG_CMD, "cmd read memory"); - - cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); - if (!cmd) { - ret = -ENOMEM; - goto out; - } - - WARN_ON(len > MAX_READ_SIZE); - len = min_t(size_t, len, MAX_READ_SIZE); - - cmd->addr = addr; - cmd->size = len; - - ret = wl1251_cmd_send(wl, CMD_READ_MEMORY, cmd, sizeof(*cmd)); - if (ret < 0) { - wl1251_error("read memory command failed: %d", ret); - goto out; - } - - /* the read command got in, we can now read the answer */ - wl1251_mem_read(wl, wl->cmd_box_addr, cmd, sizeof(*cmd)); - - if (cmd->header.status != CMD_STATUS_SUCCESS) - wl1251_error("error in read command result: %d", - cmd->header.status); - - memcpy(answer, cmd->value, len); - -out: - kfree(cmd); - return ret; -} - int wl1251_cmd_template_set(struct wl1251 *wl, u16 cmd_id, void *buf, size_t buf_len) { diff --git a/drivers/net/wireless/ti/wl1251/cmd.h b/drivers/net/wireless/ti/wl1251/cmd.h index d824ff9..5f35430 100644 --- a/drivers/net/wireless/ti/wl1251/cmd.h +++ b/drivers/net/wireless/ti/wl1251/cmd.h @@ -40,8 +40,6 @@ int wl1251_cmd_data_path_tx(struct wl1251 *wl, u8 channel, bool enable); int wl1251_cmd_join(struct wl1251 *wl, u8 bss_type, u8 channel, u16 beacon_interval, u8 dtim_interval); int wl1251_cmd_ps_mode(struct wl1251 *wl, u8 ps_mode); -int wl1251_cmd_read_memory(struct wl1251 *wl, u32 addr, void *answer, - size_t len); int wl1251_cmd_template_set(struct wl1251 *wl, u16 cmd_id, void *buf, size_t buf_len); int wl1251_cmd_scan(struct wl1251 *wl, u8 *ssid, size_t ssid_len,