From patchwork Fri Jan 9 11:14:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5598951 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DADB39F1C5 for ; Fri, 9 Jan 2015 11:14:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 123FF20480 for ; Fri, 9 Jan 2015 11:14:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CAB8204DF for ; Fri, 9 Jan 2015 11:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbbAILOv (ORCPT ); Fri, 9 Jan 2015 06:14:51 -0500 Received: from mail-we0-f171.google.com ([74.125.82.171]:33586 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932263AbbAILOs (ORCPT ); Fri, 9 Jan 2015 06:14:48 -0500 Received: by mail-we0-f171.google.com with SMTP id u56so7350932wes.2 for ; Fri, 09 Jan 2015 03:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5m5y08mtVNtxD1IPqWLDYFLR2O16LMmFJi08g9wML9M=; b=cTfQgt6fnHklCx32XwJIekQVTLTkRAZD7ATB7n6XOotr0h+dG2x/j7xh3P7Nw7y+ix SecV/MHjzJclwDRg3gIhjO7UF2ETz/yeQvS7dlbBMFhIrsrSbw9V3rbjfUGATGzCqY0r vz2EHnNdWE+iBds+HKG8qza95bh0GIqVVUMtY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5m5y08mtVNtxD1IPqWLDYFLR2O16LMmFJi08g9wML9M=; b=Z/iWmiPlopEaVeZrQXZG4nAdHhdrQqtCd0XLYZsvCv+31jfWsYLF109sUiqzI2FzAq N8Gr7wNg2lUE4ZHgen5kpaRuwHvFv6d4wxKITmFw2zPYhViRxkeplr1yv9OwAUMSDIVs BxsLsEXy3RcMHGkCZisDQn+XrIlOLSpC5H1K6UF8XX/SY53ZRDiOkpP0PjM9CMy6VMgg Y4jKAj7euSYWy4prkSStejUp3ki/MKSrZmvUg6X4zUbVQP7BuIdKg/kBw+I+NE1tv7tt b7FZk3rx+EryXbQUrryQMNNYhhbLqdqK4vpenX3qQVxYBy+IdwQ8t834Rujg5vOLI1Z8 z6Hg== X-Gm-Message-State: ALoCoQmb6NkMe3G7T2Pb/ChQARjmriDDFYblKCQrAxM4Pew0Vo/9k4x5QnVB7+uZHSfX6QPVaYd9fIV9zvU1CCpPRJnK26Hh7xI+p08ypmDmo2nN5GnSPZ/nNTbqwJSEa8k8EVEr4tIS X-Received: by 10.180.228.72 with SMTP id sg8mr4097203wic.48.1420802087222; Fri, 09 Jan 2015 03:14:47 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id gb10sm9612608wjb.21.2015.01.09.03.14.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jan 2015 03:14:46 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [RFC 2/8] ath10k: allow empty ssid vdev config Date: Fri, 9 Jan 2015 12:14:03 +0100 Message-Id: <1420802049-11962-3-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1420802049-11962-1-git-send-email-michal.kazior@tieto.com> References: <1420802049-11962-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index df3ddb9..ea7fe78 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1295,8 +1295,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 1570feb..cf90f86 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4092,8 +4092,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))