diff mbox

ath10k: document switch case fall-through in __ath10k_scan_finish

Message ID 1421096822-28698-1-git-send-email-linville@tuxdriver.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

John W. Linville Jan. 12, 2015, 9:07 p.m. UTC
Add a comment for indicating that the ATH10K_SCAN_RUNNING case falls
through to the ATH10K_SCAN_ABORTING case in __ath10k_scan_finish.  This
will document that the lack of a break is intentional.

Coverity: CID 1260017

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/wireless/ath/ath10k/mac.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Jan. 15, 2015, 10:36 a.m. UTC | #1
"John W. Linville" <linville@tuxdriver.com> writes:

> Add a comment for indicating that the ATH10K_SCAN_RUNNING case falls
> through to the ATH10K_SCAN_ABORTING case in __ath10k_scan_finish.  This
> will document that the lack of a break is intentional.
>
> Coverity: CID 1260017
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Thanks, applied to ath.git.
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index c4005670cba2..695222e57728 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -2213,6 +2213,7 @@  void __ath10k_scan_finish(struct ath10k *ar)
 	case ATH10K_SCAN_RUNNING:
 		if (ar->scan.is_roc)
 			ieee80211_remain_on_channel_expired(ar->hw);
+		/* fall through */
 	case ATH10K_SCAN_ABORTING:
 		if (!ar->scan.is_roc)
 			ieee80211_scan_completed(ar->hw,