diff mbox

[1/8] mwifiex: remove redundant nick_name variable

Message ID 1421149130-5889-2-git-send-email-patila@marvell.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

Avinash Patil Jan. 13, 2015, 11:38 a.m. UTC
This is not used anywhere execpt initialization.

Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Cathy Luo <cluo@marvell.com>
---
 drivers/net/wireless/mwifiex/main.c | 1 -
 drivers/net/wireless/mwifiex/main.h | 1 -
 2 files changed, 2 deletions(-)

Comments

Kalle Valo Jan. 23, 2015, 5:22 p.m. UTC | #1
> This is not used anywhere execpt initialization.
> 
> Signed-off-by: Avinash Patil <patila@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Cathy Luo <cluo@marvell.com>

Thanks, 6 patches applied to wireless-drivers-next.git:

5e7f03b102eb mwifiex: remove redundant nick_name variable
534cfed66caf mwifiex: set wiphy params only once
bb2703cffb2f mwifiex: do not declare wdev as pointer
7d2d4fbf4e8e mwifiex: add init parameter to init command routine
16b21941fa9a mwifiex: handle PS events on AP interface as well
770c385d2744 mwifiex: support conversion to any virtual interface type

2 patches failed to apply:

Applying: mwifiex: store permanant mac address in adapter structure
error: patch failed: drivers/net/wireless/mwifiex/init.c:285
error: drivers/net/wireless/mwifiex/init.c: patch does not apply
Patch failed at 0001 mwifiex: store permanant mac address in adapter structure

Applying: mwifiex: manage virtual interface limits efficiently
error: patch failed: drivers/net/wireless/mwifiex/init.c:286
error: drivers/net/wireless/mwifiex/init.c: patch does not apply
Patch failed at 0001 mwifiex: manage virtual interface limits efficiently

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kalle Valo Jan. 23, 2015, 5:28 p.m. UTC | #2
Kalle Valo <kvalo@codeaurora.org> writes:

>> This is not used anywhere execpt initialization.
>> 
>> Signed-off-by: Avinash Patil <patila@marvell.com>
>> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
>> Signed-off-by: Cathy Luo <cluo@marvell.com>
>
> Thanks, 6 patches applied to wireless-drivers-next.git:
>
> 5e7f03b102eb mwifiex: remove redundant nick_name variable
> 534cfed66caf mwifiex: set wiphy params only once
> bb2703cffb2f mwifiex: do not declare wdev as pointer
> 7d2d4fbf4e8e mwifiex: add init parameter to init command routine
> 16b21941fa9a mwifiex: handle PS events on AP interface as well
> 770c385d2744 mwifiex: support conversion to any virtual interface type
>
> 2 patches failed to apply:
>
> Applying: mwifiex: store permanant mac address in adapter structure
> error: patch failed: drivers/net/wireless/mwifiex/init.c:285
> error: drivers/net/wireless/mwifiex/init.c: patch does not apply
> Patch failed at 0001 mwifiex: store permanant mac address in adapter structure
>
> Applying: mwifiex: manage virtual interface limits efficiently
> error: patch failed: drivers/net/wireless/mwifiex/init.c:286
> error: drivers/net/wireless/mwifiex/init.c: patch does not apply
> Patch failed at 0001 mwifiex: manage virtual interface limits efficiently

But mwifiex doesn't compile any more so I had to drop all patches.
Please resend the whole series.
Avinash Patil Jan. 27, 2015, 11:15 a.m. UTC | #3
On Fri, 2015-01-23 at 09:28 -0800, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
> 
> >> This is not used anywhere execpt initialization.
> >> 
> >> Signed-off-by: Avinash Patil <patila@marvell.com>
> >> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> >> Signed-off-by: Cathy Luo <cluo@marvell.com>
> >
> > Thanks, 6 patches applied to wireless-drivers-next.git:
> >
> > 5e7f03b102eb mwifiex: remove redundant nick_name variable
> > 534cfed66caf mwifiex: set wiphy params only once
> > bb2703cffb2f mwifiex: do not declare wdev as pointer
> > 7d2d4fbf4e8e mwifiex: add init parameter to init command routine
> > 16b21941fa9a mwifiex: handle PS events on AP interface as well
> > 770c385d2744 mwifiex: support conversion to any virtual interface type
> >
> > 2 patches failed to apply:
> >
> > Applying: mwifiex: store permanant mac address in adapter structure
> > error: patch failed: drivers/net/wireless/mwifiex/init.c:285
> > error: drivers/net/wireless/mwifiex/init.c: patch does not apply
> > Patch failed at 0001 mwifiex: store permanant mac address in adapter structure
> >
> > Applying: mwifiex: manage virtual interface limits efficiently
> > error: patch failed: drivers/net/wireless/mwifiex/init.c:286
> > error: drivers/net/wireless/mwifiex/init.c: patch does not apply
> > Patch failed at 0001 mwifiex: manage virtual interface limits efficiently
> 
> But mwifiex doesn't compile any more so I had to drop all patches.
> Please resend the whole series.
> 

Hi Kalle,

I will rebase patches on top of master and resend.

Thanks,
Avinash



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
index a16c293..c7158e8 100644
--- a/drivers/net/wireless/mwifiex/main.c
+++ b/drivers/net/wireless/mwifiex/main.c
@@ -968,7 +968,6 @@  void mwifiex_init_priv_params(struct mwifiex_private *priv,
 	/* Initialize private structure */
 	priv->current_key_index = 0;
 	priv->media_connected = false;
-	memset(&priv->nick_name, 0, sizeof(priv->nick_name));
 	memset(priv->mgmt_ie, 0,
 	       sizeof(struct mwifiex_ie) * MAX_MGMT_IE_INDEX);
 	priv->beacon_idx = MWIFIEX_AUTO_IDX_MASK;
diff --git a/drivers/net/wireless/mwifiex/main.h b/drivers/net/wireless/mwifiex/main.h
index dd55bc1..149ef7d 100644
--- a/drivers/net/wireless/mwifiex/main.h
+++ b/drivers/net/wireless/mwifiex/main.h
@@ -554,7 +554,6 @@  struct mwifiex_private {
 #ifdef CONFIG_DEBUG_FS
 	struct dentry *dfs_dev_dir;
 #endif
-	u8 nick_name[16];
 	u16 current_key_index;
 	struct semaphore async_sem;
 	struct cfg80211_scan_request *scan_request;