From patchwork Tue Jan 20 10:26:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5667261 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 39EB99F333 for ; Tue, 20 Jan 2015 10:27:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 735BD20389 for ; Tue, 20 Jan 2015 10:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA41320254 for ; Tue, 20 Jan 2015 10:27:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbbATK1V (ORCPT ); Tue, 20 Jan 2015 05:27:21 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:63998 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbbATK1V (ORCPT ); Tue, 20 Jan 2015 05:27:21 -0500 Received: by mail-wi0-f169.google.com with SMTP id bs8so22312865wib.0 for ; Tue, 20 Jan 2015 02:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=QBwWXhDWlNFc2F9qEkLgfW+4vDdsTEXLOBzQr2oaH3w=; b=Uj6BRymijBTtgUhybgnb60HLLXHSBJWVn2Y0mmSrvMJXHLTgNUusQkeVWYWCKAz2r6 CZV/WeagOjyocOPaKgG7A8n220bswt03TL7Wtfd5qYpQMPuZksEWrP1BN5ks4Qwo9TlZ Rb9ifOVC5PgdvFsxkQPWJHkL7TFP2ozeiuHaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QBwWXhDWlNFc2F9qEkLgfW+4vDdsTEXLOBzQr2oaH3w=; b=EOuacqG7A3QzhRem6353RtlyqsdhxfDjjDfPf8+C2CDk0mGqz2zlE3P5rQ6zHc4PSN fH+jR9U0x+tcIklsSRlxumpLbg3y5XWxk7Svj77Z3tFpXfWplloU4tRYsLKz1aARXJUh 5hsN3777dlYUgwiZGMmrYGdSJUTWrfGITonrVe+rPvJP0pAZSh5Hp1DxGGUH6ucqZU3D +d3A/kfAsZ9IJEwPuc2IQTYesEyWFjM42WSRmyVU3+HKEtsGkgpKCgF8mrOyk9AhKLu2 HoFDhVos2k6HI0+cWT+HJotkjaLjRbbscDpr9U1BO8drxJHuZ8iIryOhzSc5H4KGYEiM PNQw== X-Gm-Message-State: ALoCoQl25k/GFSuFmRpXIdEsAXebKAMYL2XJFVG6M7mn+nafG2cdyDCApENpEpUxw8I+q1/+ymxTCiC3h58O1azh9BJoMV8kAPlKHRIn6SRioNEjhADLP0K9FIyJBHmCh/Lbo4wxL9CW X-Received: by 10.194.203.234 with SMTP id kt10mr14342505wjc.88.1421749639868; Tue, 20 Jan 2015 02:27:19 -0800 (PST) Received: from bob.homerouter.cpe (apn-46-76-65-212.dynamic.gprs.plus.pl. [46.76.65.212]) by mx.google.com with ESMTPSA id gu5sm2398430wib.24.2015.01.20.02.27.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 02:27:19 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath10k: disable irqs after fw crash Date: Tue, 20 Jan 2015 11:26:43 +0100 Message-Id: <1421749603-11424-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It makes little sense to keep handling irqs if fw is dead. This prevents multiple fw register dumps upon crash on some devices (seen on QCA6174). Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 3b40a86..fba6618 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2047,6 +2047,7 @@ static void ath10k_msi_err_tasklet(unsigned long data) return; } + ath10k_pci_irq_disable(ar); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); } @@ -2116,6 +2117,7 @@ static void ath10k_pci_tasklet(unsigned long data) struct ath10k_pci *ar_pci = ath10k_pci_priv(ar); if (ath10k_pci_has_fw_crashed(ar)) { + ath10k_pci_irq_disable(ar); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); return;