From patchwork Tue Jan 20 17:01:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 5671121 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DD16C9F357 for ; Tue, 20 Jan 2015 17:01:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 05D21203EB for ; Tue, 20 Jan 2015 17:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3658F20218 for ; Tue, 20 Jan 2015 17:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755413AbbATRBn (ORCPT ); Tue, 20 Jan 2015 12:01:43 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:52126 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbbATRBl (ORCPT ); Tue, 20 Jan 2015 12:01:41 -0500 Received: by mail-ob0-f177.google.com with SMTP id uy5so34371109obc.8; Tue, 20 Jan 2015 09:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=a8flKkPPq53Z7PBHy8Ydt534XDqqQqdG71RdNo+ndBc=; b=aBj39YC+4VEGd6FjLE9R3j0bXHXrxeEjD9ABAsYmnaagnWjmUAiMAVTufNbmUQjpij 1ej7i6uJG7QOQ5zaPBo//V+htYWmzK8lEzhjqAUoqW3sGluJiueEJBL+xtVY+5isIY+a xJpLgrcm4gy+MTmDjXX6/42i/hyB2dlEtMU9XuMRnpinscoWlncweFFssXJrTj+2mYeu XuqvTvfM+3enV6lyXP/y8ek2Bmuifaeuxq3vScB3w2YUgc31xSBL3kG65ixqZeP/KluE D55oZxfFiqvnoqjFYu/PfYI9eFKKa2dAp1u6O5FX7EpbGYdfa0GqyM/TDyQBwBPJm/iw dYxw== X-Received: by 10.202.62.6 with SMTP id l6mr21016202oia.59.1421773300884; Tue, 20 Jan 2015 09:01:40 -0800 (PST) Received: from linux.site ([69.76.245.152]) by mx.google.com with ESMTPSA id ox19sm7495599oeb.17.2015.01.20.09.01.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Jan 2015 09:01:40 -0800 (PST) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger , netdev@vger.kernel.org, Stable Subject: [PATCH V2 for 3.19 1/7] rtlwifi: Remove logging statement that is no longer needed Date: Tue, 20 Jan 2015 11:01:20 -0600 Message-Id: <1421773286-1039-2-git-send-email-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1421773286-1039-1-git-send-email-Larry.Finger@lwfinger.net> References: <1421773286-1039-1-git-send-email-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit e9538cf4f907 ("rtlwifi: Fix error when accessing unmapped memory in skb"), a printk was included to indicate that the condition had been reached. There is now enough evidence from other users that the fix is working. That logging statement can now be removed. Signed-off-by: Larry Finger Cc: Stable [V3.18] --- drivers/net/wireless/rtlwifi/pci.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c index c70efb9..e25faac 100644 --- a/drivers/net/wireless/rtlwifi/pci.c +++ b/drivers/net/wireless/rtlwifi/pci.c @@ -816,11 +816,8 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) /* get a new skb - if fail, old one will be reused */ new_skb = dev_alloc_skb(rtlpci->rxbuffersize); - if (unlikely(!new_skb)) { - pr_err("Allocation of new skb failed in %s\n", - __func__); + if (unlikely(!new_skb)) goto no_new; - } if (rtlpriv->use_new_trx_flow) { buffer_desc = &rtlpci->rx_ring[rxring_idx].buffer_desc