From patchwork Fri Jan 30 08:41:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5747661 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3C791BF440 for ; Fri, 30 Jan 2015 08:43:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 661A9201BB for ; Fri, 30 Jan 2015 08:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A38420225 for ; Fri, 30 Jan 2015 08:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759873AbbA3Im6 (ORCPT ); Fri, 30 Jan 2015 03:42:58 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33082 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759835AbbA3Imz (ORCPT ); Fri, 30 Jan 2015 03:42:55 -0500 Received: by mail-wg0-f50.google.com with SMTP id b13so25483921wgh.9 for ; Fri, 30 Jan 2015 00:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w1W+CAmspXWaqppOnlZ3UYziFWc39lwGq2zSSKh8eKg=; b=1EyryY5cedFR060H3euE0GQn5O3wI5iorLxugUhR+Rnw/GlMoxxq8X+DjVgae40Ahl BH9c3PkW1qfQ/jRLt6SfaHEJXoosP8oKObeLLIx+TV0fdXHrjVbQ3fL21UCH93+6El0f Lxhyt74/0DbROhZUV6wMjJncLtzq86w3v94HU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w1W+CAmspXWaqppOnlZ3UYziFWc39lwGq2zSSKh8eKg=; b=cvRjd+k9+aUdyE0GPwUzAI2S+GasBgW3zrgUp1Yakzb8HmNB7Qwk2wmYk+ZfwXx/AA Mgbl1uwtutyHxUKtN7WmGxh325jTR2IgE0aYWxjYOprRjjhFF24tb5eAxpTIivLU47Jw AhBal2JXtd6pITHMYevvxPm5T/7S/xWkvH306bwzebmRnem7dZXy73htiQNvUIEdvPVM yFY2sMCkk3YYjneUlYLbNa+WEGRm1fPbW9h6ASc6tRUWeeswmYgFmRHiyT8JWYFysIDt qy7CKVtjfjRR9mNgi/+vvUiZ9Mzf18qeHpxpLOJKWXfEaJ35Q4oms2I6xsTjSV4pfLnr sMvw== X-Gm-Message-State: ALoCoQnug7EP79U5QK/+TXpyZg03kqMXYvjGklt4qmyiQu/mJl5etPchKB4e6NURxwvujAUlYAtjM/+BshfwjBOlDt7Yh7MLZLjcyTWP0KbYMQ+lTsHNYml4n66zgtF379AH+3aQHtnc X-Received: by 10.194.94.1 with SMTP id cy1mr9233689wjb.127.1422607365589; Fri, 30 Jan 2015 00:42:45 -0800 (PST) Received: from bob.homerouter.cpe (apn-31-1-134-151.dynamic.gprs.plus.pl. [31.1.134.151]) by mx.google.com with ESMTPSA id i3sm5884655wie.23.2015.01.30.00.42.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 00:42:45 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH 1/7] ath10k: allow empty ssid vdev config Date: Fri, 30 Jan 2015 09:41:21 +0100 Message-Id: <1422607287-12289-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1422607287-12289-1-git-send-email-michal.kazior@tieto.com> References: <1422607287-12289-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index be32db9..ccafb69 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1302,8 +1302,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index ce6f0c7..97ee2e9 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4264,8 +4264,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))