| Message ID | 1424001758-29529-10-git-send-email-qca_vkondrat@qca.qualcomm.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
On Sunday, February 15, 2015 02:02:38 PM Vladimir Kondratiev wrote: > For the normal (non-sniffer) mode of operation, align Rx buffer > on 4*n+2, so IP header (after 14 bytes of Ethernet header) > will start dword aligned. This accelerated IP stack a little bit. > > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> > Kalle, please do not apply this patch. I found last minute problem with it - hardware is not always happy. For now, drop it please. I will do more testing and re-submit this patch if everything wends OK. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> writes: > On Sunday, February 15, 2015 02:02:38 PM Vladimir Kondratiev wrote: >> For the normal (non-sniffer) mode of operation, align Rx buffer >> on 4*n+2, so IP header (after 14 bytes of Ethernet header) >> will start dword aligned. This accelerated IP stack a little bit. >> >> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> >> > Kalle, > > please do not apply this patch. I found last minute problem with it - > hardware is not always happy. > > For now, drop it please. I will do more testing and re-submit this > patch if everything wends OK. Ok, I dropped this patch. Patches 1-8 are still on my queue.
diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c index 7f2f560..e1587b3 100644 --- a/drivers/net/wireless/ath/wil6210/txrx.c +++ b/drivers/net/wireless/ath/wil6210/txrx.c @@ -468,8 +468,11 @@ static int wil_rx_refill(struct wil6210_priv *wil, int count) struct vring *v = &wil->vring_rx; u32 next_tail; int rc = 0; + /* 2 bytes headroom in normal operation mode to achieve dword + * alignment for the IP header + */ int headroom = ndev->type == ARPHRD_IEEE80211_RADIOTAP ? - WIL6210_RTAP_SIZE : 0; + WIL6210_RTAP_SIZE : 2; for (; next_tail = wil_vring_next_tail(v), (next_tail != v->swhead) && (count-- > 0);
For the normal (non-sniffer) mode of operation, align Rx buffer on 4*n+2, so IP header (after 14 bytes of Ethernet header) will start dword aligned. This accelerated IP stack a little bit. Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> --- drivers/net/wireless/ath/wil6210/txrx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)