diff mbox

ssb: Silence warning for unknown backplane revision

Message ID 1424290178-25328-1-git-send-email-Larry.Finger@lwfinger.net (mailing list archive)
State Accepted
Delegated to: Kalle Valo
Headers show

Commit Message

Larry Finger Feb. 18, 2015, 8:09 p.m. UTC
When using a BCM4318 in a PCMCIA format, I get a startup message that the
device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
the message, the device works fine, This patch silences the warning.

Cc: Rafa? Mi?ecki <zajec5@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
 drivers/ssb/main.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kalle Valo Feb. 26, 2015, 12:57 p.m. UTC | #1
Larry Finger <Larry.Finger@lwfinger.net> writes:

> When using a BCM4318 in a PCMCIA format, I get a startup message that the
> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
> the message, the device works fine, This patch silences the warning.
>
> Cc: Rafa? Mi?ecki <zajec5@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Should this go to 4.0?
Larry Finger Feb. 26, 2015, 4:06 p.m. UTC | #2
On 02/26/2015 06:57 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> When using a BCM4318 in a PCMCIA format, I get a startup message that the
>> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
>> the message, the device works fine, This patch silences the warning.
>>
>> Cc: Rafa? Mi?ecki <zajec5@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Should this go to 4.0?

As this one merely stops log spamming, sending it through NEXT is OK.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kalle Valo March 3, 2015, 1:54 p.m. UTC | #3
Larry Finger <Larry.Finger@lwfinger.net> writes:

> When using a BCM4318 in a PCMCIA format, I get a startup message that the
> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
> the message, the device works fine, This patch silences the warning.
>
> Cc: Rafa? Mi?ecki <zajec5@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks, applied to wireless-drivers-next.git.
diff mbox

Patch

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 1e180c4..a48a743 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1135,6 +1135,8 @@  static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev)
 	case SSB_IDLOW_SSBREV_25:     /* TODO - find the proper REJECT bit */
 	case SSB_IDLOW_SSBREV_27:     /* same here */
 		return SSB_TMSLOW_REJECT;	/* this is a guess */
+	case SSB_IDLOW_SSBREV:
+		break;
 	default:
 		WARN(1, KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
 	}