| Message ID | 1424791381-31863-1-git-send-email-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
Larry Finger <Larry.Finger@lwfinger.net> writes: > Routine rtl_is_special_data() is supposed to identify packets that need to > use a low bit rate so that the probability of successful transmission is > high. The current version has a bug that causes all IPv6 packets to be > labelled as special, with a corresponding low rate of transmission. A > complete fix will be quite intrusive, but until that is available, all > IPv6 packets are identified as regular. > > This patch also removes a magic number. > > Reported-and-tested-by: Alan Fisher <acf@unixcube.org> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> [3.18+] > Cc: Alan Fisher <acf@unixcube.org> Should this go to 4.0?
On 02/26/2015 06:56 AM, Kalle Valo wrote: > Larry Finger <Larry.Finger@lwfinger.net> writes: > >> Routine rtl_is_special_data() is supposed to identify packets that need to >> use a low bit rate so that the probability of successful transmission is >> high. The current version has a bug that causes all IPv6 packets to be >> labelled as special, with a corresponding low rate of transmission. A >> complete fix will be quite intrusive, but until that is available, all >> IPv6 packets are identified as regular. >> >> This patch also removes a magic number. >> >> Reported-and-tested-by: Alan Fisher <acf@unixcube.org> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> Cc: Stable <stable@vger.kernel.org> [3.18+] >> Cc: Alan Fisher <acf@unixcube.org> > > Should this go to 4.0? Yes. I should have indicated that in the subject. My expectation is that any patch that has a Cc for Stable should be applied as soon as possible. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Routine rtl_is_special_data() is supposed to identify packets that need to > use a low bit rate so that the probability of successful transmission is > high. The current version has a bug that causes all IPv6 packets to be > labelled as special, with a corresponding low rate of transmission. A > complete fix will be quite intrusive, but until that is available, all > IPv6 packets are identified as regular. > > This patch also removes a magic number. > > Reported-and-tested-by: Alan Fisher <acf@unixcube.org> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> [3.18+] > Cc: Alan Fisher <acf@unixcube.org> Thanks, applied to wireless-drivers.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c index 1d46774..074f716 100644 --- a/drivers/net/wireless/rtlwifi/base.c +++ b/drivers/net/wireless/rtlwifi/base.c @@ -1386,8 +1386,11 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx) } return true; - } else if (0x86DD == ether_type) { - return true; + } else if (ETH_P_IPV6 == ether_type) { + /* TODO: Handle any IPv6 cases that need special handling. + * For now, always return false + */ + goto end; } end:
Routine rtl_is_special_data() is supposed to identify packets that need to use a low bit rate so that the probability of successful transmission is high. The current version has a bug that causes all IPv6 packets to be labelled as special, with a corresponding low rate of transmission. A complete fix will be quite intrusive, but until that is available, all IPv6 packets are identified as regular. This patch also removes a magic number. Reported-and-tested-by: Alan Fisher <acf@unixcube.org> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Stable <stable@vger.kernel.org> [3.18+] Cc: Alan Fisher <acf@unixcube.org> --- drivers/net/wireless/rtlwifi/base.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)