From patchwork Tue Mar 24 12:43:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6078431 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9FFF09F350 for ; Tue, 24 Mar 2015 12:45:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C2ACA2024D for ; Tue, 24 Mar 2015 12:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB64F2024F for ; Tue, 24 Mar 2015 12:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbbCXMpz (ORCPT ); Tue, 24 Mar 2015 08:45:55 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:35007 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbbCXMpx (ORCPT ); Tue, 24 Mar 2015 08:45:53 -0400 Received: by laae1 with SMTP id e1so26264813laa.2 for ; Tue, 24 Mar 2015 05:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HWWKEmvfgIR2N5GSnPq8tiO4DFcjaxKwVZuU1Tgw9lY=; b=iTyhQEdM9renYD9Ss4IVOY/q5X3ZhKRRZPoXXmuMkTS7IpNDN8LUH6gnXmTPixHcMz xC9tZHtFWpnMXSlXNR4xCDgQkmq8tbYr6zAGZkay6tnmfr3f4doL9TA9wWjScTJklZly WpRYN2lk00wPEtmuaDYiFfEAZsWjuWjLgKwac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HWWKEmvfgIR2N5GSnPq8tiO4DFcjaxKwVZuU1Tgw9lY=; b=V1driF91xChBGGwvNKeIr47BFittMXoYZbqCctJXOQUbSoB6HClL6StaOsjl0Sv1eD yHVaKjtw/7y6hPUVuDXAUPtJMP6+pXjoWbetNmPE8b+OZke60P4poTOfQcgOc/530mif MXf5VmAyXKVAdFWLjSr5yJdeioTWsAGg7qz+fQ6/q76267vH2lDQo0tIwv67QTL1Jtl0 z5/WI6uIlFndrhtiF9yrEByg+z+1GAl7qEvJURtGut7XFUh697h33rZOr5Z/GZRqeGyy DkkknStTSwUhTfKeIIlWVJC6X3pnsGs3ymArm7X8wb7feRPA1DJBrU+iR8B92VnROVCB 57qg== X-Gm-Message-State: ALoCoQloAmdplfycWSHRPlFGx4qAa2kQCljcceOTSCZN74cBA94Nft+RuxEZMx2aXseoRJdya46E+RSRS6WfDG96umZCa9TCPUW/0rvpGgFDJRcY5HQ69EmH4NVfaBV9INV2VYDR1xNP X-Received: by 10.152.27.202 with SMTP id v10mr3650090lag.90.1427201152068; Tue, 24 Mar 2015 05:45:52 -0700 (PDT) Received: from bob.homerouter.cpe (apn-77-113-71-242.dynamic.gprs.plus.pl. [77.113.71.242]) by mx.google.com with ESMTPSA id jp17sm901084lab.34.2015.03.24.05.45.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Mar 2015 05:45:51 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH v5 1/7] ath10k: allow empty ssid vdev config Date: Tue, 24 Mar 2015 12:43:07 +0000 Message-Id: <1427200993-7550-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1427200993-7550-1-git-send-email-michal.kazior@tieto.com> References: <1427200993-7550-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 467d88c780c7..d4804645f8c2 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1518,8 +1518,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 1f47636f204b..3ef41105b95c 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4248,8 +4248,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))