From patchwork Thu Mar 26 09:57:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6097381 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9DBB69F399 for ; Thu, 26 Mar 2015 10:00:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C210D201EC for ; Thu, 26 Mar 2015 10:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA7BB201D3 for ; Thu, 26 Mar 2015 10:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbbCZJ76 (ORCPT ); Thu, 26 Mar 2015 05:59:58 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:36022 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbCZJ75 (ORCPT ); Thu, 26 Mar 2015 05:59:57 -0400 Received: by labe2 with SMTP id e2so41087008lab.3 for ; Thu, 26 Mar 2015 02:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=+JGXPx9GyYPlZzlpGX2e13UUZKP5DL1oMk4kOy0dp6I=; b=svK6iWXF8K+/q2KJCQ0Pn/a+cyQgkOVOOrAvMkUU3biM5eszUgZNF5pQSTSV9DljtN oA1UKUEyldePwnWg3Fys4rffqdbavE54l8FnWEZ/QzXetUHBH6yHJeW8dhU+JJjvJO3N xzwwfuD7rI1dTFsTmAcpp5iqtRwecp70I82V4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+JGXPx9GyYPlZzlpGX2e13UUZKP5DL1oMk4kOy0dp6I=; b=CTuoa/Af2P1LTgIbBhw37IYnwh3dEX3TdGRudqSWqg5zMCgQEFvhpyyAnG0c9baaxq 1pFW+yqjt87cdatqTZcm0FNUsfyaRivLrj/nnRexTQXAZG5EUAZghkPBlnusY5amYsON o7TJ/SMnvTw0O+fNhxApqOIJddc6/vdDch7UlYelIcXZh9uYQFC9XK/my7JNykluGzI7 wilKA7FWX1kOvAvC29ilk5s8+6GAZBf8HIFJ3qPC0EXyiUR8Nyy+VD/3kvKPf4Z9GPQO /KtRZP9g7CL9H/nZ/Lv5MUXpqVih4BdOm4loKYmhgHtSgXDGClG9YiS63+AOM7C0WAlq 6MbA== X-Gm-Message-State: ALoCoQnCkeFhNL5hYOGKEVtiN+Tq7NIsuT+1dgJGGzNIo51GDs7QWcFz2GKJzHL4iMigvZPmKPqTErN9S064dLm0b/WjchcdUM0hxgZ9G0v+VJGl6E4enwATCpZ+b2vO8/zh8dsH1B8C X-Received: by 10.152.179.139 with SMTP id dg11mr12629909lac.28.1427363996334; Thu, 26 Mar 2015 02:59:56 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id ei4sm1140257lad.31.2015.03.26.02.59.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Mar 2015 02:59:55 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath10k: clear htt.freq Date: Thu, 26 Mar 2015 09:57:07 +0000 Message-Id: <1427363827-24125-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If htt.freq isn't cleared and contains garbage fw may discard tx packets. Prevent this from happening by clearing htt.freq properly. Possible manifestation of the problem could be not being able to send auth request/response frames on firmware with HTT >= 3.4 (when freq param was introduced), e.g. on qca6174. Fixes: 8d6d36243610 ("ath10k: fix offchan reliability") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 9b8313dcb888..36a244187b9c 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2927,6 +2927,7 @@ static void ath10k_tx(struct ieee80211_hw *hw, ath10k_dbg(ar, ATH10K_DBG_MAC, "IEEE80211_TX_CTL_NO_CCK_RATE\n"); ATH10K_SKB_CB(skb)->htt.is_offchan = false; + ATH10K_SKB_CB(skb)->htt.freq = 0; ATH10K_SKB_CB(skb)->htt.tid = ath10k_tx_h_get_tid(hdr); ATH10K_SKB_CB(skb)->vdev_id = ath10k_tx_h_get_vdev_id(ar, vif);