| Message ID | 1428095590-600-2-git-send-email-greearb@candelatech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Johannes Berg |
| Headers | show |
On Fri, 2015-04-03 at 14:13 -0700, greearb@candelatech.com wrote: > This message just fills up dmesg and/or kernel logs and does > not provide any useful information. [] > diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c [] > @@ -1696,7 +1696,7 @@ static int mac80211_hwsim_get_survey( > { > struct ieee80211_conf *conf = &hw->conf; > > - wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); > + /* wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); */ It's better, if it's really useless, to delete this than comment it out. But it's not on by default anyway, so why it an issue? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/03/2015 02:29 PM, Joe Perches wrote: > On Fri, 2015-04-03 at 14:13 -0700, greearb@candelatech.com wrote: >> This message just fills up dmesg and/or kernel logs and does >> not provide any useful information. > [] >> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c > [] >> @@ -1696,7 +1696,7 @@ static int mac80211_hwsim_get_survey( >> { >> struct ieee80211_conf *conf = &hw->conf; >> >> - wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); >> + /* wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); */ > > It's better, if it's really useless, to delete this > than comment it out. > > But it's not on by default anyway, so why it an issue? It's on on my systems...rest of the wiphy debug is normally useful, but this particular one is not and spams the logs. I don't mind removing it entirely, but thought maybe someone would want an easy way to enable it again for some reason. Thanks, Ben
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index d0e88b2..5089169 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -1696,7 +1696,7 @@ static int mac80211_hwsim_get_survey( { struct ieee80211_conf *conf = &hw->conf; - wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); + /* wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); */ if (idx != 0) return -ENOENT;