From patchwork Tue Apr 21 21:33:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Priestley X-Patchwork-Id: 6253881 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E03019F1BE for ; Tue, 21 Apr 2015 21:33:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1FFA520304 for ; Tue, 21 Apr 2015 21:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD3E42034B for ; Tue, 21 Apr 2015 21:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964826AbbDUVdd (ORCPT ); Tue, 21 Apr 2015 17:33:33 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:35194 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933745AbbDUVda (ORCPT ); Tue, 21 Apr 2015 17:33:30 -0400 Received: by wgyo15 with SMTP id o15so227578676wgy.2; Tue, 21 Apr 2015 14:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qdMZ1RxGozOMBfVhAnQtCP5sCOs9/t3n6WR8tbXNhKk=; b=odPtyXKTgBAUpFu2gcC9NWWuKebmHiR3gAEYGHTPX3bESXALsYy6u3MgiNIvqiH6av mu/wDasy8PA4EdFpMrb20/8Y/4O7yOzLqQG5qZqwYsmYBwnLKui260Dia0NjwkUDm8n8 Xj9BddvXJ1k9d+vdsVkdaPILBIqkZ3AgpbZSmVMDp2UhHt6dlTeN+IdZY85yxAtO5E6o 56gAQtvunY2LddUDni4VmfzAiTGleIRHHSLWHHiwM9m7b449iURaLqoDVY8kAEn42Mhb ArhBXpCMZmTYCZLORq2gACW9VEMaDE/c/RSLwnHmD82nWdhn0xNz9ocBt5FJZBD9psXA lqFw== X-Received: by 10.194.9.161 with SMTP id a1mr45520116wjb.39.1429652009077; Tue, 21 Apr 2015 14:33:29 -0700 (PDT) Received: from tipsey.3.home (94.197.45.248.threembb.co.uk. [94.197.45.248]) by mx.google.com with ESMTPSA id fs9sm4336352wjc.34.2015.04.21.14.33.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Apr 2015 14:33:28 -0700 (PDT) From: Malcolm Priestley To: gregkh@linuxfoundation.org Cc: linux-wireless@vger.kernel.org, Malcolm Priestley , Subject: [PATCH 3/3] staging: vt6655: lock MACvWriteBSSIDAddress. Date: Tue, 21 Apr 2015 22:33:02 +0100 Message-Id: <1429651982-4352-3-git-send-email-tvboxspy@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1429651982-4352-1-git-send-email-tvboxspy@gmail.com> References: <1429651982-4352-1-git-send-email-tvboxspy@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This function selects page 1 and cause intermittent problems on interrupt handler. lock call with spin_lock_irqsave. Signed-off-by: Malcolm Priestley Cc: # v3.19+ --- drivers/staging/vt6655/device_main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 26a6f67..8f96cc9 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1412,9 +1412,16 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, priv->current_aid = conf->aid; - if (changed & BSS_CHANGED_BSSID) + if (changed & BSS_CHANGED_BSSID) { + unsigned long flags; + + spin_lock_irqsave(&priv->lock, flags); + MACvWriteBSSIDAddress(priv->PortOffset, (u8 *)conf->bssid); + spin_unlock_irqrestore(&priv->lock, flags); + } + if (changed & BSS_CHANGED_BASIC_RATES) { priv->basic_rates = conf->basic_rates;