| Message ID | 1430840528-14998-1-git-send-email-qca_vkondrat@qca.qualcomm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes: > Fix format specifier used for dma_addr_t, namely use %pad > Debug print virtual address for the same buffer as well. > > It can be applied as: > fixup! wil6210: Add pmc debug mechanism memory management > > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> The right format for specifying the commit which this patch fixes is: Fixes: dc16427bbe65 ("wil6210: Add pmc debug mechanism memory management") See Documentatin/SubmittingPatches for more info. But I see new warnings with this patch: drivers/net/wireless/ath/wil6210/pmc.c:94:243: warning: format '%p' expects argument of type 'void *', but argument 6 has type 'dma_addr_t' [-Wformat] drivers/net/wireless/ath/wil6210/pmc.c:94:478: warning: format '%p' expects argument of type 'void *', but argument 5 has type 'dma_addr_t' [-Wformat]
diff --git a/drivers/net/wireless/ath/wil6210/pmc.c b/drivers/net/wireless/ath/wil6210/pmc.c index 3cb4f35..d34b084 100644 --- a/drivers/net/wireless/ath/wil6210/pmc.c +++ b/drivers/net/wireless/ath/wil6210/pmc.c @@ -92,9 +92,9 @@ void wil_pmc_alloc(struct wil6210_priv *wil, GFP_KERNEL); wil_dbg_misc(wil, - "%s: allocated pring %p. %zd x %d = total %zd bytes\n", + "%s: allocated pring %p => %pad. %zd x %d = total %zd bytes\n", __func__, - (void *)pmc->pring_pa, + pmc->pring_va, pmc->pring_pa, sizeof(struct vring_tx_desc), num_descriptors, sizeof(struct vring_tx_desc) * num_descriptors);
Fix format specifier used for dma_addr_t, namely use %pad Debug print virtual address for the same buffer as well. It can be applied as: fixup! wil6210: Add pmc debug mechanism memory management Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> --- drivers/net/wireless/ath/wil6210/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)