| Message ID | 1432576544-3639-1-git-send-email-shailendra.capricorn@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 05/25/2015 12:55 PM, Shailendra Verma wrote: > The variable translate is bool type.So assigning true instead of 1. > > Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com> When you submit a patch for a particular driver in the drivers/net/wireless/ tree, it is preferred that the subject start with the driver name, not with net:wireless. Accordingly, your subject should be "ray_cs: Change 1 to true for bool type variable". In fact, you can probably choose a better wording for the rest of the title, but I do not insist. Among other advantages, this choice of subject allows easy searches for patches for a given driver using 'git log'. Larry > --- > drivers/net/wireless/ray_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c > index 477f863..0881ba8 100644 > --- a/drivers/net/wireless/ray_cs.c > +++ b/drivers/net/wireless/ray_cs.c > @@ -143,7 +143,7 @@ static int psm; > static char *essid; > > /* Default to encapsulation unless translation requested */ > -static bool translate = 1; > +static bool translate = true; > > static int country = USA; > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2015-05-25 at 23:25 +0530, Shailendra Verma wrote:
> The variable translate is bool type.So assigning true instead of 1.
There are a lot these in the kernel.
$ git grep -P "^[ \t]*(?:static[ \t]+)?(?:const\s+)?bool\s+\w+\s*=\s*[01]\s*;" * | wc -l
161
Are you going to submit patches for all of them one at a time?
I suggest sending maybe 10 to 12 patches, one for each subsystem,
and cc the trivial maintainer Jiri Kosina <trivial@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index 477f863..0881ba8 100644 --- a/drivers/net/wireless/ray_cs.c +++ b/drivers/net/wireless/ray_cs.c @@ -143,7 +143,7 @@ static int psm; static char *essid; /* Default to encapsulation unless translation requested */ -static bool translate = 1; +static bool translate = true; static int country = USA;
The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com> --- drivers/net/wireless/ray_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)