From patchwork Mon May 25 18:10:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shailendra Verma X-Patchwork-Id: 6476731 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B0EBB9F401 for ; Mon, 25 May 2015 18:10:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D4D95203E3 for ; Mon, 25 May 2015 18:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E65A8203E6 for ; Mon, 25 May 2015 18:10:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751147AbbEYSKg (ORCPT ); Mon, 25 May 2015 14:10:36 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:33504 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbbEYSKe (ORCPT ); Mon, 25 May 2015 14:10:34 -0400 Received: by pdbqa5 with SMTP id qa5so73636862pdb.0; Mon, 25 May 2015 11:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=RRBJOIzfHS4w5ICioJMHkDghUVk9dPKctwHs2V0OXJI=; b=nQIXdPhCZU+/UO20z0sUFgBcoIcEeKn2iMS1YMBQA4FKFvWjmcdT/3R0TFiWaiPvFb LR1GZCKApc18CE3/w1gSL+A4fPp+X+dOCjmRDS166ZkBtFLA9cTg6gU0iG1+c9ZzQfTa /ZP0kjeKNqoMZz7rgnWAe/TY4sZFmmS1knPmw4YFUcNSB6t4c/0lNdGH9GhHPcS3Mvom 6NtrxHtH1GmgOu7FKJV3YNs/lnYwRdsMNf9DmENNKpHb6VbtpFWINblOy803Wq4w9Kp3 /p70OAcEExUw0fewRDIEwwgfG7WxTu6Vb6vwd2vXLFPuWlYeIkSiYkv1ztok6DSeMC8F t/BA== X-Received: by 10.68.135.233 with SMTP id pv9mr42221584pbb.115.1432577434130; Mon, 25 May 2015 11:10:34 -0700 (PDT) Received: from localhost.localdomain ([112.196.170.173]) by mx.google.com with ESMTPSA id ie3sm10659004pbb.49.2015.05.25.11.10.31 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 May 2015 11:10:33 -0700 (PDT) From: Shailendra Verma To: Jussi Kivilinna , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Shailendra Verma Subject: [PATCH] net:wireless:rndis_wlan - Use bool function return value Date: Mon, 25 May 2015 23:40:22 +0530 Message-Id: <1432577422-3917-1-git-send-email-shailendra.capricorn@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The function rndis_bss_info_update() has bool return type. So use bool value flase instead of NULL to return. Signed-off-by: Shailendra Verma --- drivers/net/wireless/rndis_wlan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c index d72ff8e..b2bff5c 100644 --- a/drivers/net/wireless/rndis_wlan.c +++ b/drivers/net/wireless/rndis_wlan.c @@ -2000,7 +2000,7 @@ static bool rndis_bss_info_update(struct usbnet *usbdev, if (bssid_len < sizeof(struct ndis_80211_bssid_ex) + sizeof(struct ndis_80211_fixed_ies)) - return NULL; + return false; fixed = (struct ndis_80211_fixed_ies *)bssid->ies; @@ -2009,13 +2009,13 @@ static bool rndis_bss_info_update(struct usbnet *usbdev, (int)le32_to_cpu(bssid->ie_length)); ie_len -= sizeof(struct ndis_80211_fixed_ies); if (ie_len < 0) - return NULL; + return false; /* extract data for cfg80211_inform_bss */ channel = ieee80211_get_channel(priv->wdev.wiphy, KHZ_TO_MHZ(le32_to_cpu(bssid->config.ds_config))); if (!channel) - return NULL; + return false; signal = level_to_qual(le32_to_cpu(bssid->rssi)); timestamp = le64_to_cpu(*(__le64 *)fixed->timestamp);