diff mbox

[py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class

Message ID 1434439958-9447-1-git-send-email-luca@coelho.fi (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Luca Coelho June 16, 2015, 7:32 a.m. UTC
From: Luciano Coelho <luciano.coelho@intel.com>

We should not pass self explicitly when calling the superclass's
_add_scan_attrs() in the sched_scan_start class.  Fix it.

Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
---
 lib/scan.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arend van Spriel June 19, 2015, 8:07 a.m. UTC | #1
On 06/16/15 09:32, Luca Coelho wrote:
> From: Luciano Coelho<luciano.coelho@intel.com>
>
> We should not pass self explicitly when calling the superclass's
> _add_scan_attrs() in the sched_scan_start class.  Fix it.

Sloppy maintainer at work ;-) My python knowledge need a refresh. I like 
the super() concept, but did not do the training yet. :-)

Thanks for the fix. Applied to py80211 master branch.

Regards,
Arend

> Signed-off-by: Luciano Coelho<luciano.coelho@intel.com>
> ---
>   lib/scan.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/scan.py b/lib/scan.py
> index 32cb68b..3ce242e 100644
> --- a/lib/scan.py
> +++ b/lib/scan.py
> @@ -191,7 +191,7 @@ class sched_scan_start(scan_start_base):
>   		self._matches = None
>
>   	def _add_scan_attrs(self):
> -		super(sched_scan_start, self)._add_scan_attrs(self)
> +		super(sched_scan_start, self)._add_scan_attrs()
>   		if self._interval != None:
>   			nl.nla_put_u32(self._nl_msg._msg, nl80211.ATTR_SCHED_SCAN_INTERVAL, self._interval)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/lib/scan.py b/lib/scan.py
index 32cb68b..3ce242e 100644
--- a/lib/scan.py
+++ b/lib/scan.py
@@ -191,7 +191,7 @@  class sched_scan_start(scan_start_base):
 		self._matches = None
 
 	def _add_scan_attrs(self):
-		super(sched_scan_start, self)._add_scan_attrs(self)
+		super(sched_scan_start, self)._add_scan_attrs()
 		if self._interval != None:
 			nl.nla_put_u32(self._nl_msg._msg, nl80211.ATTR_SCHED_SCAN_INTERVAL, self._interval)