From patchwork Thu Jul 9 10:27:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6754671 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B2039C05AC for ; Thu, 9 Jul 2015 10:27:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DBC6A205FF for ; Thu, 9 Jul 2015 10:27:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A62D20698 for ; Thu, 9 Jul 2015 10:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751246AbbGIK1e (ORCPT ); Thu, 9 Jul 2015 06:27:34 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:34076 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbbGIK1d (ORCPT ); Thu, 9 Jul 2015 06:27:33 -0400 Received: by lbnk3 with SMTP id k3so72345674lbn.1 for ; Thu, 09 Jul 2015 03:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=EblAmnhAe2O24dvFWkQW/owDTe4D6umhydxpmNXFW90=; b=cyXX7mhNxSKqn3w61q641Mx9aDB4r/AB/mW8LT8wjVb/gqM9xdR7E6bAQ6OLDN2EjD cOo3JLQP2qf2T5rtREPcyRzRwaujhRJ1d7zzViAKijQxi7ksxf7tJqupHoK5PuQF8odw FV61PDTZaH6zPtFm6mw3i6k72Yyb+EAX+uXlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EblAmnhAe2O24dvFWkQW/owDTe4D6umhydxpmNXFW90=; b=SAxUkivuz88x6buQRjYbt2xu5hO+MpCKKRDi8auC4PmXkMxEubeAboTB8jRh/rO4mW ie1p7+h3I/aD9HvKnbf4CIRxNzqYrsn/hx0jIuiPbORVOHbef6+SECaQVmEnVxBqRiWB CO2snvTgjDy3JhCqifqFYxULqnW39VWpe67F4YszXo0k+Yj9sB8jz7b9h5YFR2D3tMZv 9R1EuCibdZLHmxKFdLdT50GXatdwf++/KjnYFX7fPZ5DYJr45ak93a8YqSrtFQBBllOd qjHuSqcKidvaK7t2hfde2AAjwJUYP4+/s6GWCdb2V4AGv9BHM/Mh1d5OE7u4xdRLaDN2 UNVA== X-Gm-Message-State: ALoCoQnqqkxB/EyMgoubtYMSa9MeJ3jEIFaglc1xa/xoRC+dBiqU4IQTpL0UgMKpkOneHgeQScvgjkqx2xL6Bz24vDTwNnOZPBDqsupZXyQHpPTEDn3DO3fWj8FjvGlsOUHZWx1Pf9UW X-Received: by 10.112.73.33 with SMTP id i1mr14226489lbv.31.1436437651546; Thu, 09 Jul 2015 03:27:31 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by smtp.gmail.com with ESMTPSA id lb8sm1399134lbc.31.2015.07.09.03.27.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jul 2015 03:27:30 -0700 (PDT) From: Michal Kazior To: ath9k-devel@lists.ath9k.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath9k: fix moredata flag endianness in cabq tx Date: Thu, 9 Jul 2015 12:27:22 +0200 Message-Id: <1436437642-18781-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While compiling ath9k with some extra flags I've found that: ath9k/xmit.c +2473 ## 16: warning: restricted __le16 degrades to integer ath9k/xmit.c +2474 ## 36: warning: invalid assignment: &= ath9k/xmit.c +2474 ## 36: left side has type restricted __le16 ath9k/xmit.c +2474 ## 36: right side has type int There's no way for frame ftype/stype to be mistreated as the offending 'moredata' flag when considering cab queue. This could've however theoretically led sometimes to increased power consumption on connected stations as they would keep their Rx active waiting for frames that would never come. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath9k/xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index 3ad79bb4f2c2..d8cc45106f85 100644 --- a/drivers/net/wireless/ath/ath9k/xmit.c +++ b/drivers/net/wireless/ath/ath9k/xmit.c @@ -2470,8 +2470,8 @@ void ath_tx_cabq(struct ieee80211_hw *hw, struct ieee80211_vif *vif, bf = list_first_entry(&bf_q, struct ath_buf, list); hdr = (struct ieee80211_hdr *) bf->bf_mpdu->data; - if (hdr->frame_control & IEEE80211_FCTL_MOREDATA) { - hdr->frame_control &= ~IEEE80211_FCTL_MOREDATA; + if (hdr->frame_control & cpu_to_le16(IEEE80211_FCTL_MOREDATA)) { + hdr->frame_control &= ~cpu_to_le16(IEEE80211_FCTL_MOREDATA); dma_sync_single_for_device(sc->dev, bf->bf_buf_addr, sizeof(*hdr), DMA_TO_DEVICE); }