From patchwork Thu Jul 9 11:08:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6754971 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B9A5A9F319 for ; Thu, 9 Jul 2015 11:09:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF7202069E for ; Thu, 9 Jul 2015 11:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CA9A2069B for ; Thu, 9 Jul 2015 11:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128AbbGILI7 (ORCPT ); Thu, 9 Jul 2015 07:08:59 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:33580 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbGILIx (ORCPT ); Thu, 9 Jul 2015 07:08:53 -0400 Received: by laar3 with SMTP id r3so244403386laa.0 for ; Thu, 09 Jul 2015 04:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3iEyh0bcRN2cWykUIAUkEdIh0U8oNl8QpxuuuiEzZVQ=; b=N8/bVzzdE834tHoxOem5JI0VTAPLSQVXrLK6d2L5IFQ4c6W1WVNZ+ppAEG+YkvSJKi /I7L9JHxMml3qoshWBLiv9HSJLW8ZjKTzHo4uXCuzXt1+NtJ6geJeS3/6E1tdXqrDrOG ljjqITmYF7COxfU/0dZ9IR8Fzm7edSZOW0ZrI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3iEyh0bcRN2cWykUIAUkEdIh0U8oNl8QpxuuuiEzZVQ=; b=TYo8uNm4O1GFBIJOzthW/8fxqnIy3RHbSN4VGIB6temsPZCmOiJWBReLJ5kq828m9q deR12ll42Jy4AzvUD01UBAS1ar5+/jvqm1n4Qv6j1ked6PX8z3n/jIyCifZaQwDwZ/Du o2GipKNnNkOwaQ1bdQbuJSc3TemWnjONjXN3pI2eYyNvHS5H1hNTSxv96V+b/vExzQ8r VBhvDxX3r8RHGSXtvLHlv5nvbZTw9IZLlf4AeKm4PVknjdWzJSvBuMExbjeaJo+VNkP/ M1a5V/+IhVFan/TdhtCm4pAoIPf2MalUTGRKaA/pMYlkXigv4jumTfj1AUN5cbeDFYsf wnGw== X-Gm-Message-State: ALoCoQmCVwg44tfSZsUKwQHdEWEIhNPf8WrH48PSWbyhBwHITpKkSXhFAjjsLc1SQsezAuwZglEbfzCq7So6gugFCLnVz3mg7dK2Vm6ytLZhLL+KArHgfa2aF2yecWo33sqz8MgELQ99 X-Received: by 10.152.206.75 with SMTP id lm11mr13877284lac.41.1436440131367; Thu, 09 Jul 2015 04:08:51 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by smtp.gmail.com with ESMTPSA id t15sm1433507lbk.0.2015.07.09.04.08.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jul 2015 04:08:50 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH 4/6] ath10k: update vdev ps state on start Date: Thu, 9 Jul 2015 13:08:37 +0200 Message-Id: <1436440119-30231-5-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436440119-30231-1-git-send-email-michal.kazior@tieto.com> References: <1436440119-30231-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RCVD_IN_SBL_CSS,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Psmode can be forcefully enabled when vdev isn't started. It isn't guaranteed that mac80211 will re-issue psmode setting after vdev is started unless actual bss_conf.ps value has changed. Even if this doesn't fix any problems now it may prevent future breakage. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index a060b7708f4a..e25e6a8f44a5 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -6222,6 +6222,13 @@ ath10k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, arvif->is_started = true; + ret = ath10k_mac_vif_setup_ps(arvif); + if (ret) { + ath10k_warn(ar, "failed to update vdev %i ps: %d\n", + arvif->vdev_id, ret); + goto err_stop; + } + if (vif->type == NL80211_IFTYPE_MONITOR) { ret = ath10k_wmi_vdev_up(ar, arvif->vdev_id, 0, vif->addr); if (ret) { @@ -6239,6 +6246,7 @@ ath10k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, err_stop: ath10k_vdev_stop(arvif); arvif->is_started = false; + ath10k_mac_vif_setup_ps(arvif); err: mutex_unlock(&ar->conf_mutex);