From patchwork Mon Aug 3 08:55:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6928061 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3A061C05AC for ; Mon, 3 Aug 2015 08:55:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4475C2055D for ; Mon, 3 Aug 2015 08:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80D0B2054C for ; Mon, 3 Aug 2015 08:55:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141AbbHCIzH (ORCPT ); Mon, 3 Aug 2015 04:55:07 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:33873 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbbHCIzE (ORCPT ); Mon, 3 Aug 2015 04:55:04 -0400 Received: by lbqc9 with SMTP id c9so48707317lbq.1 for ; Mon, 03 Aug 2015 01:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=2ynYlmIV5IByAELfyLfThpa2wSEV/67LecXk5YjLySg=; b=VsZB+w5Sz2cFq2pkpqLrIUIsHaIfrv5/LTx0keJGALk1DMedREUGPmRBjMLrRLaSLX oMyEo9yy5fSE/9j4ifnB5KrMHPsHdv91StKPzP5fuKzvc8JN6VtzEs5dSDhcReyrwiDq IDVnV7yZwHWyC5YliF943f+6o+mmdUjZWLaHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2ynYlmIV5IByAELfyLfThpa2wSEV/67LecXk5YjLySg=; b=Lezf25fGmQoTvUU5BWWT5Q8bA4mTkcI2BuBQvwvQHUd9dOjBjoxN62kCojXsA0JdGP cDbYwjZ62ot2gC/WDKQd8P8DgCIorBEXe3QVmGsLpfy31DeVqhlkj7V0dXkN5u4HYFMj C+SCsF+f0M3IvE0860PkZutN09HyAOxUaW1Wr+Nn7GvHXVDWQWx9nbgT9PtAVfJhctpG JqdvndiSYKJ38YEyZibDnlPES/6nW5B/sbz7jC/TNyzXZEEOBFXMm36hvzasA1gj7HLT vnrGrQZk73M1/ytZ7fxBZWviEM3SMgk0Wb2KNht1jlTBHSuPwYQLC5OAfxJRlNXtFkUE SVrw== X-Gm-Message-State: ALoCoQljL+D3WxHseRo+UmW4UFIbhtVW7Qcq5aQLPGXKDMoNEvXTmlRp9/Ae1d6nzOKz0wGucBasXbNlu5oYP9xaKOwing2alenLCZfANys7q/KCWgp5Ea0XCK6b+5FYbFDVzo4BYdEHZlkwvWZOxhCD6c1ypGtd+HV6B3F3YhYVI/ymd++u7wk5FRAFfNnKrFbndQHmivO1 X-Received: by 10.152.28.73 with SMTP id z9mr15651064lag.93.1438592102184; Mon, 03 Aug 2015 01:55:02 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.10]) by smtp.gmail.com with ESMTPSA id h3sm2834668lbj.19.2015.08.03.01.55.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Aug 2015 01:55:00 -0700 (PDT) From: Michal Kazior To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Michal Kazior Subject: [PATCH] cfg80211: propagate set_wiphy failure to userspace Date: Mon, 3 Aug 2015 10:55:24 +0200 Message-Id: <1438592124-30803-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If driver failed to setup wiphy params (e.g. rts threshold, fragmentation treshold) userspace wasn't properly notified about this. This could lead to user confusion who would think the command succeeded even if that wasn't the case. Signed-off-by: Michal Kazior --- net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 76b41578a838..5849fa199f77 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -2321,6 +2321,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info) rdev->wiphy.frag_threshold = old_frag_threshold; rdev->wiphy.rts_threshold = old_rts_threshold; rdev->wiphy.coverage_class = old_coverage_class; + return result; } } return 0;