From patchwork Mon Aug 3 09:16:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6928161 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EC3119F358 for ; Mon, 3 Aug 2015 09:16:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E730C205C4 for ; Mon, 3 Aug 2015 09:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 092E420574 for ; Mon, 3 Aug 2015 09:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbbHCJQP (ORCPT ); Mon, 3 Aug 2015 05:16:15 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:36743 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbbHCJQO (ORCPT ); Mon, 3 Aug 2015 05:16:14 -0400 Received: by lbbud7 with SMTP id ud7so70412244lbb.3 for ; Mon, 03 Aug 2015 02:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=o6N4s1bLstSs/2m8ntTqUt+/PxSDx6rvajEK3JvzqHk=; b=f7xcoA8xdxECaiFIN7jGP9pdhOM3SIo1daAgGHzhc7qeu1APrdpy6LIHyiSzhqIdXZ m++HrjbIoQS3/dZa97OArCvpkzrSJUyfCxCqOk+ANC1FbLNIgWcHG7P6fhnbSDsegwPP 2oUY4R5njGO87/zhh/T0kSXAMh6jSbke1Fx1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=o6N4s1bLstSs/2m8ntTqUt+/PxSDx6rvajEK3JvzqHk=; b=F9j9/uLgz79/SuQ5SOFyfPSfh0S8CXVP0rrR1keqBfGa3nvxgI6/a9XT7KS03NYiy2 SzjFsNX6n8XtBvTofJ6L05fv99cFb3TD+ZvIdPKyguvFHJNnT62bipXRMxF0O9Q3tNY/ C8Rx/Mb0CWKs/XN6CGR90zP/NsWNuuzAOvxCBp3uHlrclNIasDpjshr3CtjtZ2GalOvp DO5iOCoKmpUMK3B4DHg64WCrrb9skni4iHfriQIUz/A04qXQsgohWeVcO3cf0bClSEQR ly8VKFmRdnGyvyXmwG54hLDKHxEO8SxJ89P/om+p2VgWz//qRAsxm6nSnXH1XZeFc0Xj g90g== X-Gm-Message-State: ALoCoQl3kAB5JC3d9KtFb/1ZJs3fOXTnF5blpAidXXUESONmMG/WkGWAnQeCC7N75xPOBmhglzcDJvlMZY24F1EFvrh0pZEpojXF6gTmIzV/JsdqpKGp2Jd9ehxISnxttdHyxlbF0Zst X-Received: by 10.152.21.71 with SMTP id t7mr15471618lae.118.1438593371824; Mon, 03 Aug 2015 02:16:11 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.10]) by smtp.gmail.com with ESMTPSA id w7sm2853101lag.42.2015.08.03.02.16.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Aug 2015 02:16:10 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH 1/2] ath10k: remove futile fragmentation threshold config Date: Mon, 3 Aug 2015 11:16:42 +0200 Message-Id: <1438593403-316-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 1010ba4c5d1c ("ath10k: unregister and remove frag_threshold callback") didn't remove all instances of (futile) fragmentation threshold configuration. No known firmware supports the parameter so don't even bother setting it. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index acd222f3b899..879af9c3bd4a 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -678,20 +678,6 @@ static int ath10k_mac_set_rts(struct ath10k_vif *arvif, u32 value) return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, value); } -static int ath10k_mac_set_frag(struct ath10k_vif *arvif, u32 value) -{ - struct ath10k *ar = arvif->ar; - u32 vdev_param; - - if (value != 0xFFFFFFFF) - value = clamp_t(u32, arvif->ar->hw->wiphy->frag_threshold, - ATH10K_FRAGMT_THRESHOLD_MIN, - ATH10K_FRAGMT_THRESHOLD_MAX); - - vdev_param = ar->wmi.vdev_param->fragmentation_threshold; - return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, value); -} - static int ath10k_peer_delete(struct ath10k *ar, u32 vdev_id, const u8 *addr) { int ret; @@ -4276,13 +4262,6 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, goto err_peer_delete; } - ret = ath10k_mac_set_frag(arvif, ar->hw->wiphy->frag_threshold); - if (ret) { - ath10k_warn(ar, "failed to set frag threshold for vdev %d: %d\n", - arvif->vdev_id, ret); - goto err_peer_delete; - } - arvif->txpower = vif->bss_conf.txpower; ret = ath10k_mac_txpower_recalc(ar); if (ret) {