From patchwork Wed Aug 5 04:55:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6946131 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A340B9F38B for ; Wed, 5 Aug 2015 04:55:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D17CE204AB for ; Wed, 5 Aug 2015 04:55:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6706A203FB for ; Wed, 5 Aug 2015 04:55:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750884AbbHEEzJ (ORCPT ); Wed, 5 Aug 2015 00:55:09 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:36018 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbbHEEzI (ORCPT ); Wed, 5 Aug 2015 00:55:08 -0400 Received: by labgo9 with SMTP id go9so20902205lab.3 for ; Tue, 04 Aug 2015 21:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=grfLzUA0IPIsDl0ufTStcS2zhLQx41Hn7OkHGYT4jFM=; b=2i/x1wB3rrN2Hew7C5MpoSj3Kf5hsOYVUAdmcP3gYTydZsjQ5R6P33EIyn9AuOqPhz vzTWoKHtN9kNZF80MQ+kiBql/KdT6l+nacUAX3F2pizPJvWUE1EUNMaiokwNUuKbGz5w BVKe2rMx058SAxTzluT7RiguF/uYhZUawLSzc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=grfLzUA0IPIsDl0ufTStcS2zhLQx41Hn7OkHGYT4jFM=; b=HmcxMxzfOXCa0BLn/3L+aCM5bJ8FI8FelIrGrDka3fpq0OhdlXWX1cvlxa44quW59n 7kLJtfh3NuDS9HgJzMSVx+A4yhijasgQQH32x+my/hEitjEOp5qAx5ENCPfRUkJoGJCM /Bi5mTEmiNxGnTyYoxExR/ErOy8WqV56OJqinZM5gPxIGlIFG2PeXKd/0QJS9CWYechE Tm3jH2d1aNx9IuIxuzGCK+s8Qe38vm1VXnysV/Az18EScArtj7MNtAFSiXY6dr3CxZLg /W2WlimoHiSAeY3OU2MnohqMsBZFsgQzpLOZQ00pPjA6VrHuXcc8SZM/BlzUxlfWcqAL L2Uw== X-Gm-Message-State: ALoCoQnsZYjpYHfFhyv69hL/2ZjNmZ2+MpS/V58BsCwAd/ULMV/Czp7w3WyrvQkPb87HEIMuUHrTdzCfDrtJJyDXC9Zgsc0Mv0WiJ3t8nLK035a7LqEHyZThliDypLQJjvGvXO+IHH+j X-Received: by 10.112.131.98 with SMTP id ol2mr7796319lbb.56.1438750505738; Tue, 04 Aug 2015 21:55:05 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.10]) by smtp.gmail.com with ESMTPSA id ol6sm289001lbb.37.2015.08.04.21.55.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Aug 2015 21:55:05 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath10k: initialize fw_features var Date: Wed, 5 Aug 2015 06:55:37 +0200 Message-Id: <1438750537-27781-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If firmware did not have any feature flags set the var would be left with values found on the stack (i.e. garbage) yielding print string like this: (...) features \xffffffa6m:^R\xfffffffb?\xffffffc4^E Fixes: b27bc5a40f91 ("ath10k: dump fw features during probing") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index 1a33bf04b7b7..f7aa1c73b481 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -124,7 +124,7 @@ EXPORT_SYMBOL(ath10k_info); void ath10k_print_driver_info(struct ath10k *ar) { - char fw_features[128]; + char fw_features[128] = {}; ath10k_core_get_fw_features_str(ar, fw_features, sizeof(fw_features));