From patchwork Thu Aug 6 12:46:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6958591 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BCDFC9F39D for ; Thu, 6 Aug 2015 12:46:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0F6220706 for ; Thu, 6 Aug 2015 12:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F21B20702 for ; Thu, 6 Aug 2015 12:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755548AbbHFMq2 (ORCPT ); Thu, 6 Aug 2015 08:46:28 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:33156 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755471AbbHFMq1 (ORCPT ); Thu, 6 Aug 2015 08:46:27 -0400 Received: by lbbyj8 with SMTP id yj8so41981690lbb.0 for ; Thu, 06 Aug 2015 05:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=MHJnTfvv+FzbsX4A4o3wWNkXPqA8dj6WYfBz7yYhkrg=; b=tTGlzOPkE9VJN6ARUmfpovdEX22x5Fgv8NrhAf6s3yEcVRVMokbdKVZ7EBHXG+AfWT 5cSZVsbeNgQ6Ots/HSjt+VAruAbSCiVgOHb/SufurVtmaHBWFNt3jVLL+NN911+wzCVW SYigOY6ztPWBnJheV9G2y9fBDREJFCfL8I8EQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MHJnTfvv+FzbsX4A4o3wWNkXPqA8dj6WYfBz7yYhkrg=; b=NwolHv3Vw9fksRf9RQkpIUY/5leb+Y3nHSZyNACI7HItr4vbnLx6q44cl+9fcynJyB Ru8npuOG313nSljgKOBd2nIwixQr8NJt3sPcNQJPmXE2ZJ9FFzM8zOG0IExDTtnTQmmQ 58xTZuqophyFWgtUgdav4RUOilgv9R4GnOmrmngPzrSNh+Drc1hHzbIjTUUyTy+GibRf 0InX7c5AV+tUZK9ZWizFVNC89aa/2azM/a2iHhHRxL0SQIrA17Qpj/zJatpgZ66sSpH1 pV97CEKcTup5ct8J3yoMp+y/8mgIha5kk9hJOSQNHY10ZywjGCB5tNVQO3/YMDunOuQa U6hQ== X-Gm-Message-State: ALoCoQmI8d3NKD2kAFrHygG3H7RI+XoVHayYWGMoltPm3bvLfOFJmj+S5T77+toap+cwkhU2k5czDyrwWC4URs6bDJdGXYze4V+gL2STvAWqvomRNmKSLzMAbdBaBEbizD0GAAEnf8rQ X-Received: by 10.152.6.194 with SMTP id d2mr1296869laa.93.1438865185909; Thu, 06 Aug 2015 05:46:25 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.10]) by smtp.gmail.com with ESMTPSA id x4sm1362661lae.19.2015.08.06.05.46.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Aug 2015 05:46:25 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath10k: wake up offchannel queue properly Date: Thu, 6 Aug 2015 14:46:54 +0200 Message-Id: <1438865214-1651-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Once HTT Tx queue got full offchannel queue was stopped and never woken up again. This broke, e.g. P2P. This could be reproduced after running a lot of traffic enough to saturate 100% of the driver Tx queue and then trying to send offchannel traffic. Fixes: 96d828d45e16 ("ath10k: rework tx queue locking") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index acd222f3b899..c7ff0c8a5bd4 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3002,6 +3002,8 @@ void ath10k_mac_tx_unlock(struct ath10k *ar, int reason) IEEE80211_IFACE_ITER_RESUME_ALL, ath10k_mac_tx_unlock_iter, ar); + + ieee80211_wake_queue(ar->hw, ar->hw->offchannel_tx_hw_queue); } void ath10k_mac_vif_tx_lock(struct ath10k_vif *arvif, int reason)