From patchwork Wed Oct 28 06:59:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glen Lee X-Patchwork-Id: 7506781 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9345FBEEA4 for ; Wed, 28 Oct 2015 06:57:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 486642081D for ; Wed, 28 Oct 2015 06:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB4FE20818 for ; Wed, 28 Oct 2015 06:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827AbbJ1G5o (ORCPT ); Wed, 28 Oct 2015 02:57:44 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:41497 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbbJ1G5n (ORCPT ); Wed, 28 Oct 2015 02:57:43 -0400 Received: from glen-ubuntu.corp.atmel.com (10.161.101.13) by eusmtp01.atmel.com (10.161.101.31) with Microsoft SMTP Server id 14.3.235.1; Wed, 28 Oct 2015 07:57:37 +0100 From: Glen Lee To: CC: , , , , , , , , Subject: [PATCH 01/80] staging: wilc1000: remove unnecessary parentheses around Date: Wed, 28 Oct 2015 15:59:21 +0900 Message-ID: <1446015640-29398-1-git-send-email-glen.lee@atmel.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Leo Kim This patch removes the checks reported by checkpatch.pl for unnecessary parentheses around. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 48 +++++++++++++++---------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index f658594..acc6552b 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -332,7 +332,7 @@ static s32 Handle_SetChannel(struct host_if_drv *hif_drv, strWID.id = (u16)WID_CURRENT_CHANNEL; strWID.type = WID_CHAR; - strWID.val = (char *)&(pstrHostIFSetChan->set_ch); + strWID.val = (char *)&pstrHostIFSetChan->set_ch; strWID.size = sizeof(char); PRINT_D(HOSTINF_DBG, "Setting channel\n"); @@ -356,7 +356,7 @@ static s32 Handle_SetWfiDrvHandler(struct host_if_drv *hif_drv, strWID.id = (u16)WID_SET_DRV_HANDLER; strWID.type = WID_INT; - strWID.val = (s8 *)&(pstrHostIfSetDrvHandler->u32Address); + strWID.val = (s8 *)&pstrHostIfSetDrvHandler->u32Address; strWID.size = sizeof(u32); result = send_config_pkt(SET_CFG, &strWID, 1, @@ -381,7 +381,7 @@ static s32 Handle_SetOperationMode(struct host_if_drv *hif_drv, strWID.id = (u16)WID_SET_OPERATION_MODE; strWID.type = WID_INT; - strWID.val = (s8 *)&(pstrHostIfSetOperationMode->u32Mode); + strWID.val = (s8 *)&pstrHostIfSetOperationMode->u32Mode; strWID.size = sizeof(u32); result = send_config_pkt(SET_CFG, &strWID, 1, @@ -881,7 +881,7 @@ static s32 Handle_Scan(struct host_if_drv *hif_drv, strWIDList[u32WidsCount].id = WID_SCAN_TYPE; strWIDList[u32WidsCount].type = WID_CHAR; strWIDList[u32WidsCount].size = sizeof(char); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrHostIFscanAttr->type)); + strWIDList[u32WidsCount].val = (s8 *)&pstrHostIFscanAttr->type; u32WidsCount++; strWIDList[u32WidsCount].id = WID_SCAN_CHANNEL_LIST; @@ -904,7 +904,7 @@ static s32 Handle_Scan(struct host_if_drv *hif_drv, strWIDList[u32WidsCount].id = WID_START_SCAN_REQ; strWIDList[u32WidsCount].type = WID_CHAR; strWIDList[u32WidsCount].size = sizeof(char); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrHostIFscanAttr->src)); + strWIDList[u32WidsCount].val = (s8 *)&pstrHostIFscanAttr->src; u32WidsCount++; if (hif_drv->enuHostIFstate == HOST_IF_CONNECTED) @@ -1069,7 +1069,7 @@ static s32 Handle_Connect(struct host_if_drv *hif_drv, strWIDList[u32WidsCount].id = (u16)WID_11I_MODE; strWIDList[u32WidsCount].type = WID_CHAR; strWIDList[u32WidsCount].size = sizeof(char); - strWIDList[u32WidsCount].val = (s8 *)(&(hif_drv->strWILC_UsrConnReq.u8security)); + strWIDList[u32WidsCount].val = (s8 *)&hif_drv->strWILC_UsrConnReq.u8security; u32WidsCount++; if (memcmp("DIRECT-", pstrHostIFconnectAttr->ssid, 7)) @@ -1732,21 +1732,21 @@ static int Handle_Key(struct host_if_drv *hif_drv, if (pstrHostIFkeyAttr->action & ADDKEY_AP) { PRINT_D(HOSTINF_DBG, "Handling WEP key\n"); - PRINT_D(GENERIC_DBG, "ID Hostint is %d\n", (pstrHostIFkeyAttr->attr.wep.index)); + PRINT_D(GENERIC_DBG, "ID Hostint is %d\n", pstrHostIFkeyAttr->attr.wep.index); strWIDList[0].id = (u16)WID_11I_MODE; strWIDList[0].type = WID_CHAR; strWIDList[0].size = sizeof(char); - strWIDList[0].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.mode)); + strWIDList[0].val = (s8 *)&pstrHostIFkeyAttr->attr.wep.mode; strWIDList[1].id = WID_AUTH_TYPE; strWIDList[1].type = WID_CHAR; strWIDList[1].size = sizeof(char); - strWIDList[1].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.auth_type)); + strWIDList[1].val = (s8 *)&pstrHostIFkeyAttr->attr.wep.auth_type; strWIDList[2].id = (u16)WID_KEY_ID; strWIDList[2].type = WID_CHAR; - strWIDList[2].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.index)); + strWIDList[2].val = (s8 *)&pstrHostIFkeyAttr->attr.wep.index; strWIDList[2].size = sizeof(char); pu8keybuf = kmemdup(pstrHostIFkeyAttr->attr.wep.key, @@ -1808,7 +1808,7 @@ static int Handle_Key(struct host_if_drv *hif_drv, } else { strWID.id = (u16)WID_KEY_ID; strWID.type = WID_CHAR; - strWID.val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.index)); + strWID.val = (s8 *)&pstrHostIFkeyAttr->attr.wep.index; strWID.size = sizeof(char); PRINT_D(HOSTINF_DBG, "Setting default key index\n"); @@ -1839,7 +1839,7 @@ static int Handle_Key(struct host_if_drv *hif_drv, strWIDList[0].id = (u16)WID_11I_MODE; strWIDList[0].type = WID_CHAR; strWIDList[0].size = sizeof(char); - strWIDList[0].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wpa.mode)); + strWIDList[0].val = (s8 *)&pstrHostIFkeyAttr->attr.wpa.mode; strWIDList[1].id = (u16)WID_ADD_RX_GTK; strWIDList[1].type = WID_STR; @@ -1914,7 +1914,7 @@ _WPARxGtk_end_case_: strWIDList[0].id = (u16)WID_11I_MODE; strWIDList[0].type = WID_CHAR; strWIDList[0].size = sizeof(char); - strWIDList[0].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wpa.mode)); + strWIDList[0].val = (s8 *)&pstrHostIFkeyAttr->attr.wpa.mode; strWIDList[1].id = (u16)WID_ADD_PTK; strWIDList[1].type = WID_STR; @@ -2160,9 +2160,7 @@ static void Handle_GetLinkspeed(struct host_if_drv *hif_drv) result = -EFAULT; } - up(&(hif_drv->hSemGetLINKSPEED)); - - + up(&hif_drv->hSemGetLINKSPEED); } s32 Handle_GetStatistics(struct host_if_drv *hif_drv, struct rf_info *pstrStatistics) @@ -2173,31 +2171,31 @@ s32 Handle_GetStatistics(struct host_if_drv *hif_drv, struct rf_info *pstrStatis strWIDList[u32WidsCount].id = WID_LINKSPEED; strWIDList[u32WidsCount].type = WID_CHAR; strWIDList[u32WidsCount].size = sizeof(char); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u8LinkSpeed)); + strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u8LinkSpeed; u32WidsCount++; strWIDList[u32WidsCount].id = WID_RSSI; strWIDList[u32WidsCount].type = WID_CHAR; strWIDList[u32WidsCount].size = sizeof(char); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->s8RSSI)); + strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->s8RSSI; u32WidsCount++; strWIDList[u32WidsCount].id = WID_SUCCESS_FRAME_COUNT; strWIDList[u32WidsCount].type = WID_INT; strWIDList[u32WidsCount].size = sizeof(u32); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u32TxCount)); + strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u32TxCount; u32WidsCount++; strWIDList[u32WidsCount].id = WID_RECEIVED_FRAGMENT_COUNT; strWIDList[u32WidsCount].type = WID_INT; strWIDList[u32WidsCount].size = sizeof(u32); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u32RxCount)); + strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u32RxCount; u32WidsCount++; strWIDList[u32WidsCount].id = WID_FAILED_COUNT; strWIDList[u32WidsCount].type = WID_INT; strWIDList[u32WidsCount].size = sizeof(u32); - strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u32TxFailureCount)); + strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u32TxFailureCount; u32WidsCount++; result = send_config_pkt(GET_CFG, strWIDList, u32WidsCount, @@ -2608,8 +2606,8 @@ static int Handle_RegisterFrame(struct host_if_drv *hif_drv, *pu8CurrByte++ = pstrHostIfRegisterFrame->bReg; *pu8CurrByte++ = pstrHostIfRegisterFrame->u8Regid; - memcpy(pu8CurrByte, &(pstrHostIfRegisterFrame->u16FrameType), sizeof(u16)); - + memcpy(pu8CurrByte, &pstrHostIfRegisterFrame->u16FrameType, + sizeof(u16)); strWID.size = sizeof(u16) + 2; @@ -4206,7 +4204,7 @@ s32 host_int_init(struct net_device *dev, struct host_if_drv **hif_drv_handler) setup_timer(&hif_drv->hRemainOnChannel, ListenTimerCB, 0); - sema_init(&(hif_drv->gtOsCfgValuesSem), 1); + sema_init(&hif_drv->gtOsCfgValuesSem, 1); down(&hif_drv->gtOsCfgValuesSem); hif_drv->enuHostIFstate = HOST_IF_IDLE; @@ -4302,7 +4300,7 @@ s32 host_int_deinit(struct host_if_drv *hif_drv) wilc_mq_destroy(&hif_msg_q); } - down(&(hif_drv->gtOsCfgValuesSem)); + down(&hif_drv->gtOsCfgValuesSem); ret = remove_handler_in_list(hif_drv); if (ret)