From patchwork Thu Mar 17 18:41:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 8613931 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E3E94C0553 for ; Thu, 17 Mar 2016 18:41:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F11772021B for ; Thu, 17 Mar 2016 18:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AF1720279 for ; Thu, 17 Mar 2016 18:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031531AbcCQSl3 (ORCPT ); Thu, 17 Mar 2016 14:41:29 -0400 Received: from mail-ob0-f196.google.com ([209.85.214.196]:35261 "EHLO mail-ob0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031513AbcCQSlW (ORCPT ); Thu, 17 Mar 2016 14:41:22 -0400 Received: by mail-ob0-f196.google.com with SMTP id e7so6741432obv.2 for ; Thu, 17 Mar 2016 11:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=CI9qonkMjZErsGlR1GARkxVJzYJEU3e1Hss8UOUfFkQ=; b=nHGyVJ3rl+Ma+9eH7+9naNZyomiNnM1RkpZ84goMQeO0nnXZ/OPGQ8b4U9m8jh6ah1 /TWLRhGW3xJeTt8O2h0R0lRVhy+29DfNsuBcpDFqNcW3NLlrVASkIKkYOY6TjNl5asMH 768Nz1NcgYZzcSrABFudDB9Mq/GngQp+M8tPC/Gnvl4PxzvED3DssAg81DXIeK8UR+jF 1Lmfd7LqUAeoojJhMKSPlSZE7Bkam9NA6HEWvWrjxSqRGtinUZeS+o2Kl2wgH4ShsHhZ zXjREm/wglQwv8MQ3e8XrrjStvqcKR0OVoHWVr39DoNtX5GPmVfHY8fWXu1fPRPAurJb Zfxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=CI9qonkMjZErsGlR1GARkxVJzYJEU3e1Hss8UOUfFkQ=; b=CYHnTuvkJeYrbLe1X/BFYANvK6oWI7uliEbsjHD1Aa8+KGGlN5s77S3CK2OVG1I8/i 96O9hBtVAaizBqyTfhG3UR0E9tU9kJYgzz1wDZrKta9r0sL4v9um9qlSs6y+tpivKNQF SX6AaV+mNshyT8bRGh3z5iJlGEqNRYLegJifvU65Gk8rqQUbx1qydd9sIxTD7hFdnxMY iGzhfKUPtRdd2R9hFdyLUg6/b7cKiAxp7R5pUySuAzqlnT9GFnrQHIfThTswSHJL9u6W b7UZUv2RfKtuNQ3xeglh9an4tt794bMNtaSkFgOHjbxpjS9EirFOzlkcuKh6KqQ5GSr/ MTFw== X-Gm-Message-State: AD7BkJLZahE+4JLJlb+zxGP1YMcgpAv3zK6aYzIpCRFOuDT0pZ1vDfsr3TR2h5BiszW1hA== X-Received: by 10.182.113.138 with SMTP id iy10mr2165855obb.27.1458240082018; Thu, 17 Mar 2016 11:41:22 -0700 (PDT) Received: from linux.site (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id n5sm4221436obi.20.2016.03.17.11.41.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Mar 2016 11:41:21 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Larry Finger Subject: [PATCH 8/9] rtlwifi: rtl8723be: Fix Smatch warnings Date: Thu, 17 Mar 2016 13:41:03 -0500 Message-Id: <1458240064-31422-9-git-send-email-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1458240064-31422-1-git-send-email-Larry.Finger@lwfinger.net> References: <1458240064-31422-1-git-send-email-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY, URIBL_BLACK autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Smatch reports the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:1726 _rtl8723be_phy_path_a_rx_iqk() warn: inconsistent indenting drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2304 _rtl8723be_phy_lc_calibrate() warn: inconsistent indenting drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2609 _rtl8723be_phy_set_rf_power_state() warn: inconsistent indenting CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c:306 _rtl8723be_get_txpower_writeval_by_regulatory() warn: inconsistent indenting Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 10 ++++------ drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c | 4 ++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c index b7b73cb..445f681 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c @@ -1723,8 +1723,8 @@ static u8 _rtl8723be_phy_path_a_rx_iqk(struct ieee80211_hw *hw) /* Allen 20131125 */ tmp = (reg_eac & 0x03FF0000) >> 16; - if ((tmp & 0x200) > 0) - tmp = 0x400 - tmp; + if ((tmp & 0x200) > 0) + tmp = 0x400 - tmp; /* if Tx is OK, check whether Rx is OK */ if (!(reg_eac & BIT(27)) && (((reg_ea4 & 0x03FF0000) >> 16) != 0x132) && @@ -2301,8 +2301,7 @@ static void _rtl8723be_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t) } else { rtl_write_byte(rtlpriv, REG_TXPAUSE, 0x00); } -RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "\n"); - + RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "\n"); } static void _rtl8723be_phy_set_rfpath_switch(struct ieee80211_hw *hw, @@ -2606,8 +2605,7 @@ static bool _rtl8723be_phy_set_rf_power_state(struct ieee80211_hw *hw, "IPS Set eRf nic enable\n"); rtstatus = rtl_ps_enable_nic(hw); } while (!rtstatus && (initializecount < 10)); - RT_CLEAR_PS_LEVEL(ppsc, - RT_RF_OFF_LEVL_HALT_NIC); + RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC); } else { RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG, "Set ERFON sleeped:%d ms\n", diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c index 5ed4492..97f5a03 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/rf.c @@ -303,8 +303,8 @@ static void _rtl8723be_get_txpower_writeval_by_regulatory( [chnlgroup][index + (rf ? 8 : 0)] & (0x7f << (i * 8))) >> (i * 8)); - if (pwr_diff_limit[i] > pwr_diff) - pwr_diff_limit[i] = pwr_diff; + if (pwr_diff_limit[i] > pwr_diff) + pwr_diff_limit[i] = pwr_diff; } customer_limit = (pwr_diff_limit[3] << 24) |