diff mbox

iwlwifi: pcie: remove duplicate assignment of variable isr_stats

Message ID 1459164824-6994-1-git-send-email-colin.king@canonical.com (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show

Commit Message

Colin King March 28, 2016, 11:33 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

isr_stats is written twice with the same value, remove one of the
redundant assignments to isr_stats.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Emmanuel Grumbach March 28, 2016, 11:39 a.m. UTC | #1
On Mon, 2016-03-28 at 12:33 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> isr_stats is written twice with the same value, remove one of the

> redundant assignments to isr_stats.

> 

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

> ---



Applied - thanks.

>  drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c

> b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c

> index 4be3c35..253e4f0 100644

> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c

> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c

> @@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq,

> void *dev_id)

>  	struct msix_entry *entry = dev_id;

>  	struct iwl_trans_pcie *trans_pcie =

> iwl_pcie_get_trans_pcie(entry);

>  	struct iwl_trans *trans = trans_pcie->trans;

> -	struct isr_statistics *isr_stats = isr_stats = &trans_pcie

> ->isr_stats;

> +	struct isr_statistics *isr_stats = &trans_pcie->isr_stats;

>  	u32 inta_fh, inta_hw;

>  

>  	lock_map_acquire(&trans->sync_cmd_lockdep_map);
diff mbox

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
index 4be3c35..253e4f0 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
@@ -1805,7 +1805,7 @@  irqreturn_t iwl_pcie_irq_msix_handler(int irq, void *dev_id)
 	struct msix_entry *entry = dev_id;
 	struct iwl_trans_pcie *trans_pcie = iwl_pcie_get_trans_pcie(entry);
 	struct iwl_trans *trans = trans_pcie->trans;
-	struct isr_statistics *isr_stats = isr_stats = &trans_pcie->isr_stats;
+	struct isr_statistics *isr_stats = &trans_pcie->isr_stats;
 	u32 inta_fh, inta_hw;
 
 	lock_map_acquire(&trans->sync_cmd_lockdep_map);