From patchwork Thu Apr 14 15:18:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 8838611 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DB4CF9F3A0 for ; Thu, 14 Apr 2016 15:22:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0F69120374 for ; Thu, 14 Apr 2016 15:22:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3163202FF for ; Thu, 14 Apr 2016 15:21:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932670AbcDNPTM (ORCPT ); Thu, 14 Apr 2016 11:19:12 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:36061 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756474AbcDNPTJ (ORCPT ); Thu, 14 Apr 2016 11:19:09 -0400 Received: by mail-pf0-f180.google.com with SMTP id e128so46847926pfe.3; Thu, 14 Apr 2016 08:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=5rheoiTSp6qFJnkvzG52kd8lVFeFutdR4rlMDAMOjd8=; b=qqFGay2f5apqIONaJvXxY+a69Pzipm2uhSryww47HsTPqU/HYS4YpKkHES/Cuou3Er K5wEWKDaDHHJWhFGJcS0dlAgUjagp2c22PhVs/ZELGy3TJDgM+Rxa0CcDijfpmX3Ft1t pN9+QFo50fuSO6bcSYgnpseqUgIbGKmz2xt76K7FBunJndVf+noNeRoGIL4SH1BTkysm HY+qpwTw3vGI14ib4JfWsG4TBSOH8EhgKpx+r3LpidCOfpXYR3If74betwe8hvyRj2pS Cdrsh80/k09AJ1UMx0IGqQhaVBjtku5YSJdRdx+2dW7X5j3zunPHZe4CXxvN/B9CPrt3 q3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5rheoiTSp6qFJnkvzG52kd8lVFeFutdR4rlMDAMOjd8=; b=OSFFz13DoOiha4pCOkbKfBQLFD6wJKy1468p0DQYOlTaRpfmd6AwU3AQhnMMDzs7R5 jE+OeJK+h5ChS3cIB8z5A4xILc9HB5/xAj8gbfQLH3ul2k90nkV53wduC/sfDbTwNAJJ 0R0LjSqpYJkoyobg2gytblPDWKTODHDP8HmKaP/c3rbzh6ig+mhcdas//fcyJxnx2IkH CWqsRFpevLHCgOPS3z31DZJe8WZYJvQlcQ47Hqq2KSGBTHQ3SqUpcTjxe4t1ILGAOJha yIbo9wCUvtYMUZTADC5hApDIsikzAXVzoOaWrxKzYzHBSlqdS2UYuSS9wJ1LcHgr1o88 9UOA== X-Gm-Message-State: AOPr4FUAbbDXfOqdHPUb2YeO5mwWAv7PvdA/gtG3UBt1TTEc3Nal6ViJrCe8wls+jIN28Q== X-Received: by 10.98.93.142 with SMTP id n14mr3851675pfj.37.1460647149010; Thu, 14 Apr 2016 08:19:09 -0700 (PDT) Received: from localhost.localdomain ([103.24.124.194]) by smtp.gmail.com with ESMTPSA id ch2sm58792826pad.28.2016.04.14.08.19.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Apr 2016 08:19:07 -0700 (PDT) From: Sudip Mukherjee To: Johnny Kim , Austin Shin , Chris Park , Tony Cho , Glen Lee , Leo Kim , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 1/2] staging: wilc1000: fix double unlock Date: Thu, 14 Apr 2016 20:48:48 +0530 Message-Id: <1460647129-22740-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The semaphore was being released twice, once at the beginning of the thread and then again when the thread is about to close. The semaphore is acquired immediately after creating the thread so we should be releasing it when the thread ends. Signed-off-by: Sudip Mukherjee --- drivers/staging/wilc1000/linux_wlan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index a858552..5643a3d 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -313,7 +313,6 @@ static int linux_wlan_txq_task(void *vp) vif = netdev_priv(dev); wl = vif->wilc; - up(&wl->txq_thread_started); while (1) { down(&wl->txq_event);