From patchwork Mon Apr 18 19:48:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geoff Lansberry X-Patchwork-Id: 8874661 X-Patchwork-Delegate: sameo@linux.intel.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6674DBF29F for ; Mon, 18 Apr 2016 19:49:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5BAF3201BC for ; Mon, 18 Apr 2016 19:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 462942015E for ; Mon, 18 Apr 2016 19:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbcDRTtP (ORCPT ); Mon, 18 Apr 2016 15:49:15 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:35235 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbcDRTtO (ORCPT ); Mon, 18 Apr 2016 15:49:14 -0400 Received: by mail-qg0-f47.google.com with SMTP id f74so2575365qge.2 for ; Mon, 18 Apr 2016 12:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kuvee-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cAq2kR1NywYOszX9Q15AGQcLEXM5PTVFQ6QIORJr36w=; b=FTp7JtZfnVC4v8G6gCtmTbdvM+owqbrq3GbvVZ44v/ZfkVjHgNaP6ZEWAWccp7rLZW yxMEHOb1q4JfONcKARb877jXREABvrjsDFjHJii1u0MMO8AEmMMHD1lldQx4ybcNlbK6 Bw7KiSVx6KWDgjnB5ng1okfw1H/Qu8+C5p9tcQTa/Pyu0B6y95I+reyR2ai5iclow4OY TtRQDDATJXS1B00UL7VMNDO/AloSCVheKsaZMBTrlnzkYhoQToR4wg8R5yUjb4YSCEOa AOLAAkz04gUfya8DuWiL0AxeviXICRdtUbcPMurgi9w/lD9Dtz3O0al/c0UM4CMY8n5E ShAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cAq2kR1NywYOszX9Q15AGQcLEXM5PTVFQ6QIORJr36w=; b=G0bi6k/7Yjid38MBdkA7TRUj9SqTHhSWqL4Sm5J1aq1ZN0WwQQT9kXa/cWp7I4fZUX FvLdVz8vesh03NUq/wXCwljsBlo7QdqWPsXDSLXLP4SOZxcU5x/b57hyPMRW7M+fXC2h nUf/lffqfo8uhDsy9wBVqbQtuTOOLnlqyWoWdGwoJ0gqCC26kJ4YnkrVyJvzQ3xD5Pk6 tEYxlB4HGe+pITEUwJdrsgIPijEtY77lr/Xpe5fMOfpuXlv8ZPT0g3iL/F5ipWgPWWiW 5CLJAWPbJ4n21kAR4wNWv89AZGMBCC21ZlyQJmnl6q3ni6ItrhPUygGSziugLXcP3eLJ J2iA== X-Gm-Message-State: AOPr4FX3veXBkYU+NjKebRRGkr3APyd/jskbXPkQbNYn+O3lPfJkeA7WXpPA5JL9aElKTg== X-Received: by 10.55.104.148 with SMTP id d142mr20846616qkc.93.1461008953831; Mon, 18 Apr 2016 12:49:13 -0700 (PDT) Received: from localhost (c-76-28-119-232.hsd1.ma.comcast.net. [76.28.119.232]) by smtp.gmail.com with ESMTPSA id f4sm27019918qhd.31.2016.04.18.12.49.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 18 Apr 2016 12:49:13 -0700 (PDT) From: Geoff Lansberry To: linux-wireless@vger.kernel.org Cc: lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, sameo@linux.intel.com, mgreer@animalcreek.com, justin@kuvee.com, Geoff Lansberry Subject: [PATCH 3/4] NFC: trf7970a: add device tree option for 27MHz clock Date: Mon, 18 Apr 2016 15:48:40 -0400 Message-Id: <1461008921-15100-4-git-send-email-geoff@kuvee.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461008921-15100-1-git-send-email-geoff@kuvee.com> References: <1461008921-15100-1-git-send-email-geoff@kuvee.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Geoff Lansberry --- .../devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ drivers/nfc/trf7970a.c | 28 +++++++++++++--------- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt index 09c5056..bf25f39 100644 --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt @@ -22,6 +22,7 @@ Optional SoC Specific Properties: - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum where an extra byte is returned by Read Multiple Block commands issued to Type 5 tags. +- crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz Example (for ARM-based BeagleBone with TRF7970A on SPI1): @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1): irq-status-read-quirk; en2-rf-quirk; t5t-rmb-extra-byte-quirk; + crystal_27mhz; status = "okay"; }; }; diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index 447b6c9..74210f9 100644 --- a/drivers/nfc/trf7970a.c +++ b/drivers/nfc/trf7970a.c @@ -1072,12 +1072,11 @@ static int trf7970a_init(struct trf7970a *trf) trf->chip_status_ctrl &= ~TRF7970A_CHIP_STATUS_RF_ON; - ret = trf7970a_write(trf, TRF7970A_MODULATOR_SYS_CLK_CTRL, 0); + ret = trf7970a_write(trf, TRF7970A_MODULATOR_SYS_CLK_CTRL, + trf->modulator_sys_clk_ctrl); if (ret) goto err_out; - trf->modulator_sys_clk_ctrl = 0; - ret = trf7970a_write(trf, TRF7970A_ADJUTABLE_FIFO_IRQ_LEVELS, TRF7970A_ADJUTABLE_FIFO_IRQ_LEVELS_WLH_96 | TRF7970A_ADJUTABLE_FIFO_IRQ_LEVELS_WLL_32); @@ -1194,30 +1193,32 @@ static int trf7970a_in_config_rf_tech(struct trf7970a *trf, int tech) dev_dbg(trf->dev, "rf technology: %d\n", tech); + trf->modulator_sys_clk_ctrl = (trf->modulator_sys_clk_ctrl&0xF8); + switch (tech) { case NFC_DIGITAL_RF_TECH_106A: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_14443A_106; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_OOK; trf->guard_time = TRF7970A_GUARD_TIME_NFCA; break; case NFC_DIGITAL_RF_TECH_106B: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_14443B_106; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10; trf->guard_time = TRF7970A_GUARD_TIME_NFCB; break; case NFC_DIGITAL_RF_TECH_212F: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_FELICA_212; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10; trf->guard_time = TRF7970A_GUARD_TIME_NFCF; break; case NFC_DIGITAL_RF_TECH_424F: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_FELICA_424; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10; trf->guard_time = TRF7970A_GUARD_TIME_NFCF; break; case NFC_DIGITAL_RF_TECH_ISO15693: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_15693_SGL_1OF4_2648; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_OOK; trf->guard_time = TRF7970A_GUARD_TIME_15693; break; default: @@ -1582,22 +1583,24 @@ static int trf7970a_tg_config_rf_tech(struct trf7970a *trf, int tech) dev_dbg(trf->dev, "rf technology: %d\n", tech); + trf->modulator_sys_clk_ctrl = (trf->modulator_sys_clk_ctrl&0xF8); + switch (tech) { case NFC_DIGITAL_RF_TECH_106A: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_NFC_NFC_CE_MODE | TRF7970A_ISO_CTRL_NFC_CE | TRF7970A_ISO_CTRL_NFC_CE_14443A; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_OOK; break; case NFC_DIGITAL_RF_TECH_212F: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_NFC_NFC_CE_MODE | TRF7970A_ISO_CTRL_NFC_NFCF_212; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10; break; case NFC_DIGITAL_RF_TECH_424F: trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_NFC_NFC_CE_MODE | TRF7970A_ISO_CTRL_NFC_NFCF_424; - trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10; + trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10; break; default: dev_dbg(trf->dev, "Unsupported rf technology: %d\n", tech); @@ -2072,6 +2075,9 @@ static int trf7970a_probe(struct spi_device *spi) return ret; } + if (of_property_read_bool(np, "crystal_27MHz")) + trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ; + if (of_property_read_bool(np, "en2-rf-quirk")) trf->quirks |= TRF7970A_QUIRK_EN2_MUST_STAY_LOW;