diff mbox

[4/4] rtl8xxxu: fix typo on variable name, compare against correct variable

Message ID 1465497530-18510-5-git-send-email-Jes.Sorensen@redhat.com (mailing list archive)
State Accepted
Commit c70410cb91de70707a507ee7beef7021a5a89f0d
Delegated to: Kalle Valo
Headers show

Commit Message

Jes Sorensen June 9, 2016, 6:38 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

path_b_ok is being assigned but immediately after path_a_ok is being
compared to the value 0x03.  This appears to be a typo on the
variable name, compare path_b_ok instead.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo June 16, 2016, 2:49 p.m. UTC | #1 
Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> path_b_ok is being assigned but immediately after path_a_ok is being
> compared to the value 0x03.  This appears to be a typo on the
> variable name, compare path_b_ok instead.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>

Thanks, 1 patch applied to wireless-drivers.git:

c70410cb91de rtl8xxxu: fix typo on variable name, compare against correct variable
diff mbox

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
index 65c079a..5b825fa 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
@@ -1144,7 +1144,7 @@  static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
 
 		for (i = 0; i < retry; i++) {
 			path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
-			if (path_a_ok == 0x03) {
+			if (path_b_ok == 0x03) {
 				val32 = rtl8xxxu_read32(priv,
 							REG_RX_POWER_BEFORE_IQK_B_2);
 				result[t][6] = (val32 >> 16) & 0x3ff;