From patchwork Tue Aug 9 19:54:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Engelmayer X-Patchwork-Id: 9272147 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 298816082E for ; Tue, 9 Aug 2016 19:54:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BF6C26785 for ; Tue, 9 Aug 2016 19:54:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 105DD27F4B; Tue, 9 Aug 2016 19:54:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 808C926785 for ; Tue, 9 Aug 2016 19:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299AbcHITyp (ORCPT ); Tue, 9 Aug 2016 15:54:45 -0400 Received: from mout.gmx.net ([212.227.15.15]:62324 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbcHITyo (ORCPT ); Tue, 9 Aug 2016 15:54:44 -0400 Received: from localhost.localdomain ([81.217.123.197]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LyWAQ-1bBugv0cUQ-015po4; Tue, 09 Aug 2016 21:54:19 +0200 From: Christian Engelmayer To: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn Cc: kvalo@codeaurora.org, arnd@arndb.de, joe@perches.com, linux-wireless@vger.kernel.org, Christian Engelmayer Subject: [PATCH] rtlwifi: rtl8723ae: Fix leak in _rtl8723e_read_adapter_info() Date: Tue, 9 Aug 2016 21:54:12 +0200 Message-Id: <1470772452-24642-1-git-send-email-cengelma@gmx.at> X-Mailer: git-send-email 2.7.4 X-Provags-ID: V03:K0:xBcPz/4c535X2vQrpyfm8W0FvIkyPLmVAPhp2R3Py8jmLJZpIia GnI/6HcT6qs4GY4c/VBvhaXz9KspZc4O3EipvJHqa9TVuzfu5G52/1FRgeqi1E4u4bhCTrb O85MaK6YjRhZBQS/a/VcY6QD5ki5zjz9iNumkmApdAisewsyQtnbEnaVzBg+x2RXWKTY9yq /UBCPDxms8elPJpH5q+lA== X-UI-Out-Filterresults: notjunk:1; V01:K0:PujjXMNCN6U=:1NXH/w34rOIpLileqBwnnT pVhArPDGZtKPy0ZiWPT2I/b1Fnwk21aankD9PSeyzalZauJglC2iqVGMffvkON3vwLRHtbrEw aTtREm+ZREJTSoUeYp7gkCNWScSGLc83cdYaMp2ddNNkiJSHwLQ+R4JeHjm5cH4Hba/de6+qo icNsb2JDUfuG/1ZZ0ofbe9KGfmGgofdxfPwG1YsjvFibWyqzIgnRD4QN+aFkThJF4qHuxtqo9 h8UfjoUpNEhCBlRgKlNvaRXOZ/QQmGPaQDH6brhX/tctg2JQGY9CGGw3ME705jELIE1qL4bJy rX5IREMUib4Ve7ZpIQlMTf/SVGxHVfRHbApa44E0BWaBj/V7EaZXYjWHoD4KZlusRBBcvsN7y Aq0BY4FT6oM88aan0QdM6gWkdcyBKvPI2hNkwJQqYQ40vAHiaIjbTXmytTW9MxFbSL1i8jMTX JRGYyMKuiOPDCOFf80OSrkXCRXGdeicVmeVswgqM+y4ZE/JLe4jX3/xc00KL4md2h1dyZwQM2 dXs9/iE21AZ+Wk4chAYcXGhdJf2Zr/4d5wsadJE7jUAuesrY2BaKoTMfvYyvYf3cLhpwLwlYd QupvnfKr9FcsbZiZt55RZ0N++Z9I4A3eCoqYsRulMoyvWXMM+bIctZQpTzsqh3+XvUQODUkW4 jQ+zsWnIHkODEtJpRFhieKpsXHnUwWtWVfmzw580Hwu3SrymQIieos/ogAPlHfeGfA0QvTnlO jv5VBqHG9mcNF+ZPTSBwzJQcypDY0WowO4F43GW4grx9Cjm6ZYG2XrEOAio= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In case of (rtlhal->oem_id != RT_CID_DEFAULT), the function directly returns and leaks the already allocated hwinfo memory. Go through the correct exit path. Signed-off-by: Christian Engelmayer Acked-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c index b88c7ee72dbf..ba30efc2d195 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c @@ -1654,7 +1654,7 @@ static void _rtl8723e_read_adapter_info(struct ieee80211_hw *hw, rtlefuse->autoload_failflag, hwinfo); if (rtlhal->oem_id != RT_CID_DEFAULT) - return; + goto exit; switch (rtlefuse->eeprom_oemid) { case EEPROM_CID_DEFAULT: