diff mbox

[1/3] mwifiex: make "PCI-E is not the winner" print more informative

Message ID 1472137518-10431-2-git-send-email-sgruszka@redhat.com (mailing list archive)
State Accepted
Commit fd3fbb65cab86c07f5881ccb919a440497c0960d
Delegated to: Kalle Valo
Headers show

Commit Message

Stanislaw Gruszka Aug. 25, 2016, 3:05 p.m. UTC 
Printing ret and adapter->winner do not provide any useful information
as those are always 0 at point where the massage is printed. Print value
read from reg->fw_status register instead.

Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Kalle Valo Sept. 3, 2016, 5:03 p.m. UTC | #1 
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Printing ret and adapter->winner do not provide any useful information
> as those are always 0 at point where the massage is printed. Print value
> read from reg->fw_status register instead.
> 
> Stanislaw Gruszka <sgruszka@redhat.com>

Thanks, 3 patches applied to wireless-drivers-next.git:

fd3fbb65cab8 mwifiex: make "PCI-E is not the winner" print more informative
09dd9ec598c3 mwifiex: print status of FW ready event
b9aebb69ecd3 mwifiex: do not print dot when downloading FW
diff mbox

Patch

diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 453ab6a..8abbbfe 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -2074,8 +2074,7 @@  mwifiex_check_winner_status(struct mwifiex_adapter *adapter)
 		adapter->winner = 1;
 	} else {
 		mwifiex_dbg(adapter, ERROR,
-			    "PCI-E is not the winner <%#x,%d>, exit dnld\n",
-			    ret, adapter->winner);
+			    "PCI-E is not the winner <%#x>", winner);
 	}
 
 	return ret;