From patchwork Thu Aug 25 20:44:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denis Kenzior X-Patchwork-Id: 9299955 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8E43460757 for ; Thu, 25 Aug 2016 20:46:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F4A22939E for ; Thu, 25 Aug 2016 20:46:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 73F47293AA; Thu, 25 Aug 2016 20:46:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D41852939E for ; Thu, 25 Aug 2016 20:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757982AbcHYUq3 (ORCPT ); Thu, 25 Aug 2016 16:46:29 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34361 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755789AbcHYUq1 (ORCPT ); Thu, 25 Aug 2016 16:46:27 -0400 Received: by mail-oi0-f68.google.com with SMTP id t127so5481205oie.1 for ; Thu, 25 Aug 2016 13:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=5MUUWOe229EwdGzOVc3+n7j81yR1HFSZ0tcQjnv5As8=; b=RlSGM075cxq1iixH2lfBwQrcUs9qKgziI36uxNfWdFhT9BCoYZTOZJE6LD1rmroV4o jKMt8Kc5yUzVHgIfO37SxY3iHDUleej1dqT1T0AQKbsotk6Dkqyiqom97tqUUx+bMwId kLNZC0PKpqS3MMI1G7V71/fkNbsLbEAzuQsYtwllLB6RK0Knq84MoHPJeimpA74VYe4x gp9VToW5fXm6qJBnvhGOIAQ5fTuyGJnNxxsQSanR8zW7sSJtJa+U4oFuA0oStYo36TTs GOPz3UfF6da506t8nbm3ClW1IyZAVE44w2IdxjAIWgc46I2Hx6NkvvpO5qghS8z76dEU qcBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5MUUWOe229EwdGzOVc3+n7j81yR1HFSZ0tcQjnv5As8=; b=jwMoe3fg2p4qMbyQhgePqjAT9rZrNQjrIjg6Pc7AkH34z1rS8Mlqnbz78KJQ0xzIZZ RMeKnUeRDkUnkyii+JIfUAyKXnLeNeb0+RMs5clTfzAKZtOn4eJF2T33BGMSqAyIuE6t 0j2TJhTIpBWmHMPTxjzHWxYBR2Cze9CFMCE0jXiGDIYUFuPLD6a3ThM03Esc3tdDy+db E/Kt9JKbwyPzM2aOBeg/avAWlxIArFEU6U+WGNouH33vBsTWfeDOIr0LYY1nf9WOp+fD cmKhGAeZtaJ/O112wcKDTW1ACFxkgLECp8NtjxJWr4n9UbnMKklQi+3MvkyNEoQr20Qj zFGQ== X-Gm-Message-State: AE9vXwOQVrofWY7vVFeNFhXERNtNvAk8mLrcdcX3tARKSCg0BAPW8+dV2ft9vm+GD61P5A== X-Received: by 10.157.8.118 with SMTP id 109mr8457675oty.17.1472157881775; Thu, 25 Aug 2016 13:44:41 -0700 (PDT) Received: from localhost.localdomain (cpe-70-114-247-242.austin.res.rr.com. [70.114.247.242]) by smtp.gmail.com with ESMTPSA id t12sm7287170ota.9.2016.08.25.13.44.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 25 Aug 2016 13:44:41 -0700 (PDT) From: Denis Kenzior To: linux-wireless@vger.kernel.org Cc: Denis Kenzior Subject: [PATCH] nl80211: Fix unfiltered GET_INTERFACE dumps Date: Thu, 25 Aug 2016 15:44:44 -0500 Message-Id: <1472157884-3174-1-git-send-email-denkenz@gmail.com> X-Mailer: git-send-email 2.7.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP dump_wiphy_parse only assigns filter_wiphy if one of the supported NL80211 attributes is present. So for unfiltered dumps, filter_wiphy was always initialized to 0, and only interface 0 was dumped. This was introduced in commit 2d75da13fbb957e955d212555b91101cef36f0ce. Reported-by: Arend Van Spriel Signed-off-by: Denis Kenzior --- net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 95d55d2..ddc994a 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -2534,6 +2534,7 @@ static int nl80211_dump_interface(struct sk_buff *skb, struct netlink_callback * struct nl80211_dump_wiphy_state state = {}; int ret; + state.filter_wiphy = -1; ret = nl80211_dump_wiphy_parse(skb, cb, &state); if (ret) return ret;