From patchwork Wed Aug 23 19:32:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 9918195 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 834E9602CB for ; Wed, 23 Aug 2017 19:33:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 733FE28A18 for ; Wed, 23 Aug 2017 19:33:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 671B228A1C; Wed, 23 Aug 2017 19:33:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E50628A18 for ; Wed, 23 Aug 2017 19:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932619AbdHWTdN (ORCPT ); Wed, 23 Aug 2017 15:33:13 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:37072 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932467AbdHWTdJ (ORCPT ); Wed, 23 Aug 2017 15:33:09 -0400 Received: by mail-lf0-f68.google.com with SMTP id s12so298786lfk.4 for ; Wed, 23 Aug 2017 12:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nFDmY4sEGBoymCV9cZVz0GTSHT/NYiorN6uwOIhNGao=; b=t/Y4tFVSjn7I3+UX5HuNTn25nnvTpK2kYBL9Chgp0jcNqXbO3qtk30l5wk5DN49G4T l3IMfCZiiBr2C7wI9lwDkOKC827odt4wPRJ5KVEt/nGz1ZUL73X1NTafU7K8kwOITuNa jzVqqhB8vl+H+/5FAwXASHyXdQnT2OoVvjqRxrkiKfAGMrpSElI3dxe9LjtsWon7np7O 0HVZH3Hn9gc2OzknARgDSDMGdRK3B1ginZ1x5r/rWpNnU/vxoejsAeYJn/baxdWJ97/2 9JxzA+ml+pYe8o+E+hJKldlVktNT+sGFWvtBMSnCMilRTW6Yssg6Go5T4d/pplcvg949 HU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nFDmY4sEGBoymCV9cZVz0GTSHT/NYiorN6uwOIhNGao=; b=M36H0D4VatDKpzQJYwJPt1zu5E1eexgBDAQNCPU/A4cXced01jkRTaMY9uY0vVQXMM ZDSFrqIwIJvpGvwabn7PDzSDzCE4YaeU4ixyiGh0mqheQuuGnszxlX/nuQYsapLo/obo ikkT6C+mySb2BsMUmcmZz6DwK750/JvScLkZ9uZyKP+3xfIL3QzoDd12R+GpvEVyflAp npwNOSO5Ao8SoYybD6jkg6bHKylD/3l3khYIa921xoG4dHpCOUOlHRr8NB8qgz6dZ10x Ah05xObRn+hKz8eoCrXl+KYa9+JlmMe1jRdRgYPEHRzBrvggw4uywbweqPcU0V/sQFS6 HPRA== X-Gm-Message-State: AHYfb5hQZSM9JkOEXoXmShic+KhUchfn4UF2SlznTMgh7kJzh9NbYcjW a+z/AFTwmykqyIJNHlM= X-Received: by 10.25.81.131 with SMTP id g3mr1184452lfl.259.1503516787979; Wed, 23 Aug 2017 12:33:07 -0700 (PDT) Received: from erik-mate-1604.lan (90-227-62-61-no75.tbcn.telia.com. [90.227.62.61]) by smtp.gmail.com with ESMTPSA id r196sm368509lfe.38.2017.08.23.12.33.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Aug 2017 12:33:07 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cc: Erik Stromdahl Subject: [PATCH v2] ath10k: sdio: remove unused struct member Date: Wed, 23 Aug 2017 21:32:58 +0200 Message-Id: <1503516778-5835-1-git-send-email-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP irq_wq in struct ath10k_sdio is a remnant from an earlier version of the sdio patchset. Its use was removed as a result of Kalle's review, but somehow the struct member survived. It is not used and can therefore safely be removed. Signed-off-by: Erik Stromdahl --- V2: Fix typo in commit log (It's -> Its) --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ---- drivers/net/wireless/ath/ath10k/sdio.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 48268f0..03a69e5 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func) sdio_claim_host(ar_sdio->func); - wake_up(&ar_sdio->irq_wq); - if (ret && ret != -ECANCELED) ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n", ret); @@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func, goto err_free_bmi_buf; } - init_waitqueue_head(&ar_sdio->irq_wq); - for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++) ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]); diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h index 3f61c67..4ff7b54 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.h +++ b/drivers/net/wireless/ath/ath10k/sdio.h @@ -210,8 +210,6 @@ struct ath10k_sdio { /* temporary buffer for BMI requests */ u8 *bmi_buf; - wait_queue_head_t irq_wq; - bool is_disabled; struct workqueue_struct *workqueue;