From patchwork Wed Aug 30 19:51:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ganapathi Bhat X-Patchwork-Id: 9930709 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B9E3E6032A for ; Wed, 30 Aug 2017 19:56:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC6EB28700 for ; Wed, 30 Aug 2017 19:56:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A127B2875F; Wed, 30 Aug 2017 19:56:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E9E128700 for ; Wed, 30 Aug 2017 19:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750828AbdH3Tz7 (ORCPT ); Wed, 30 Aug 2017 15:55:59 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:43192 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbdH3Tz6 (ORCPT ); Wed, 30 Aug 2017 15:55:58 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v7UJsQc3006991 for ; Wed, 30 Aug 2017 12:55:58 -0700 Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2cnt3m3r9e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 30 Aug 2017 12:55:57 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 30 Aug 2017 12:55:56 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 30 Aug 2017 12:55:55 -0700 Received: from localhost (unknown [10.31.130.81]) by maili.marvell.com (Postfix) with ESMTP id D01A13F703F; Wed, 30 Aug 2017 12:55:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by localhost (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v7UJrLMK003426; Thu, 31 Aug 2017 01:23:21 +0530 Received: (from root@localhost) by localhost (8.14.4/8.14.4/Submit) id v7UJrLkR003423; Thu, 31 Aug 2017 01:23:21 +0530 From: Ganapathi Bhat To: CC: Cathy Luo , Xinming Hu , Zhiyuan Yang , James Cao , Mangesh Malusare , Ganapathi Bhat Subject: [PATCH 1/2] mwifiex: resubmit failed to submit RX URBs in main thread Date: Thu, 31 Aug 2017 01:21:13 +0530 Message-ID: <1504122674-3379-2-git-send-email-gbhat@marvell.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1504122674-3379-1-git-send-email-gbhat@marvell.com> References: <1504122674-3379-1-git-send-email-gbhat@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-08-30_08:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708300303 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: James Cao Current driver has 6 Rx data URBs. Once any packet received kernel calls our callback, in which the same URB will be resubmitted after Rx indication. In URB submission function a new skb will be allocated since the previous one is passed to upper layer (freed later). Since the skb is from a special pool (not regular memory), skb allocation may fail when kernel holds a lot of Rx packets on some low resource platforms. The URB will not be resubmitted in this no free skb case. If driver fails to resubmit all 6 URBs, Rx will stop. To cover this scenario check and resubmit Rx URBs in main thread. Signed-off-by: James Cao Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat --- drivers/net/wireless/marvell/mwifiex/main.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c index ee40b73..c78014b 100644 --- a/drivers/net/wireless/marvell/mwifiex/main.c +++ b/drivers/net/wireless/marvell/mwifiex/main.c @@ -247,6 +247,7 @@ int mwifiex_main_process(struct mwifiex_adapter *adapter) { int ret = 0; unsigned long flags; + struct usb_card_rec *usb_card; spin_lock_irqsave(&adapter->main_proc_lock, flags); @@ -278,6 +279,16 @@ int mwifiex_main_process(struct mwifiex_adapter *adapter) break; } + /* Try to resubmit RX URB if sunmission failed earlier */ + if (!atomic_read(&adapter->rx_pending) && + adapter->iface_type == MWIFIEX_USB) { + usb_card = adapter->card; + if (atomic_read(&usb_card->rx_data_urb_pending) < + MWIFIEX_RX_DATA_URB && + adapter->if_ops.submit_rem_rx_urbs) + adapter->if_ops.submit_rem_rx_urbs(adapter); + } + /* Handle pending interrupt if any */ if (adapter->int_status) { if (adapter->hs_activated)