| Message ID | 1510496506-4428-1-git-send-email-rfried@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Sun 12 Nov 06:21 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar <eilsar@codeaurora.org> > > If the value for the firmware configuration parameters BTC_STATIC_LEN_LE_BT > and BTC_STATIC_LEN_LE_WLAN are not set the duty cycle between BT and WLAN > is such that if BT (including BLE) is active WLAN gets 0 bandwidth. > When tuning these parameters having a too high value for WLAN means that BLE performance degrades. > The "sweet" point of roughly half of the maximal values was empirically found to achieve > a balance between BLE and Wi-Fi coexistence performance. > Thanks for the patch! Just some minor comments. Please limit subject to 50 chars and wrap body at 72 chars. > Signed-off-by: Eyal Ilsar <eilsar@codeaurora.org> > Signed-off-by: Ramon Fried <rfried@codeaurora.org> > --- > drivers/net/wireless/ath/wcn36xx/smd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c > index 9c6590d..1c75987 100644 > --- a/drivers/net/wireless/ath/wcn36xx/smd.c > +++ b/drivers/net/wireless/ath/wcn36xx/smd.c > @@ -72,8 +72,10 @@ struct wcn36xx_cfg_val { > WCN36XX_CFG_VAL(DYNAMIC_PS_POLL_VALUE, 0), > WCN36XX_CFG_VAL(TX_PWR_CTRL_ENABLE, 1), > WCN36XX_CFG_VAL(ENABLE_CLOSE_LOOP, 1), > - WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0), I don't see a need for moving this line. > + WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_BT, 120000), > + WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_WLAN, 30000), These looks reasonable, are we okay leaving the other coexistence properties at their preconfigured values? > WCN36XX_CFG_VAL(MAX_ASSOC_LIMIT, 10), > + WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0), > WCN36XX_CFG_VAL(ENABLE_MCC_ADAPTIVE_SCHEDULER, 0), Regards, Bjorn
Ramon Fried <rfried@codeaurora.org> writes: > From: Eyal Ilsar <eilsar@codeaurora.org> > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active > WLAN gets 0 bandwidth. When tuning these parameters having a too high > value for WLAN means that BLE performance degrades. The "sweet" point > of roughly half of the maximal values was empirically found to achieve > a balance between BLE and Wi-Fi coexistence performance. > > Signed-off-by: Eyal Ilsar <eilsar@codeaurora.org> > Signed-off-by: Ramon Fried <rfried@codeaurora.org> Then submit a new version of the patch then please include the version number: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing So after fixing Bjorn's comments the next version should be v3.
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 9c6590d..1c75987 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -72,8 +72,10 @@ struct wcn36xx_cfg_val { WCN36XX_CFG_VAL(DYNAMIC_PS_POLL_VALUE, 0), WCN36XX_CFG_VAL(TX_PWR_CTRL_ENABLE, 1), WCN36XX_CFG_VAL(ENABLE_CLOSE_LOOP, 1), - WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0), + WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_BT, 120000), + WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_WLAN, 30000), WCN36XX_CFG_VAL(MAX_ASSOC_LIMIT, 10), + WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0), WCN36XX_CFG_VAL(ENABLE_MCC_ADAPTIVE_SCHEDULER, 0), };