| Message ID | 1518793909-15573-5-git-send-email-ajay.kathat@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Fri, Feb 16, 2018 at 08:41:41PM +0530, Ajay Singh wrote: > Fix "Alignment should match open parenthesis" issue found by > checkpatch.pl script. > > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> > --- > drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c > index e98fc8e..2e2187b 100644 > --- a/drivers/staging/wilc1000/coreconfigurator.c > +++ b/drivers/staging/wilc1000/coreconfigurator.c > @@ -320,8 +320,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer, > get_ssid(msa, network_info->ssid, &network_info->ssid_len); > get_BSSID(msa, network_info->bssid); > > - network_info->ch = get_current_channel_802_11n(msa, > - rx_len + FCS_LEN); > + network_info->ch = get_current_channel_802_11n(msa, rx_len > + + FCS_LEN); Greg has already applied this which is fine, but I probably would have left this as is. Normally a rule is that the '+' character should be on the first line, and also it's slightly easier to read when the argument is one one line instead of split across two. But it doesn't matter much either way. We'll probably end up re-writing great swaths of this code. regards, dan carpenter
diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c index e98fc8e..2e2187b 100644 --- a/drivers/staging/wilc1000/coreconfigurator.c +++ b/drivers/staging/wilc1000/coreconfigurator.c @@ -320,8 +320,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer, get_ssid(msa, network_info->ssid, &network_info->ssid_len); get_BSSID(msa, network_info->bssid); - network_info->ch = get_current_channel_802_11n(msa, - rx_len + FCS_LEN); + network_info->ch = get_current_channel_802_11n(msa, rx_len + + FCS_LEN); index = MAC_HDR_LEN + TIME_STAMP_LEN;
Fix "Alignment should match open parenthesis" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)