| Message ID | 1528375527-22761-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 371d5e9d99e1e6051ce8bd02ab3db4d43be62b85 |
| Delegated to: | Kalle Valo |
| Headers | show |
On Thu, Jun 7, 2018 at 3:45 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Older gcc (< 4.4) doesn't like files starting with a Unicode BOM: > > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program > > Remove the BOM, the rest of the file is plain ASCII anyway. > > Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text > > and after: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text > > Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Thanks Geert ! Acked-by: Ramon Fried <ramon.fried@gmail.com> > --- > drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wireless/ath/wcn36xx/testmode.c > index 1279064a3b716c2e..51a038022c8b8040 100644 > --- a/drivers/net/wireless/ath/wcn36xx/testmode.c > +++ b/drivers/net/wireless/ath/wcn36xx/testmode.c > @@ -1,4 +1,4 @@ > -/* > +/* > * Copyright (c) 2018, The Linux Foundation. All rights reserved. > * > * Permission to use, copy, modify, and/or distribute this software for any > -- > 2.7.4 > > > _______________________________________________ > wcn36xx mailing list > wcn36xx@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/wcn36xx
Geert Uytterhoeven <geert@linux-m68k.org> writes: > Older gcc (< 4.4) doesn't like files starting with a Unicode BOM: > > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program > > Remove the BOM, the rest of the file is plain ASCII anyway. > > Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text > > and after: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text > > Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> I'll queue this for 4.18.
Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Older gcc (< 4.4) doesn't like files starting with a Unicode BOM: > > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program > drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program > > Remove the BOM, the rest of the file is plain ASCII anyway. > > Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text > > and after: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text > > Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Ramon Fried <ramon.fried@gmail.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-current branch of ath.git, thanks. 371d5e9d99e1 wcn36xx: Remove Unicode Byte Order Mark from testcode
diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wireless/ath/wcn36xx/testmode.c index 1279064a3b716c2e..51a038022c8b8040 100644 --- a/drivers/net/wireless/ath/wcn36xx/testmode.c +++ b/drivers/net/wireless/ath/wcn36xx/testmode.c @@ -1,4 +1,4 @@ -/* +/* * Copyright (c) 2018, The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for any
Older gcc (< 4.4) doesn't like files starting with a Unicode BOM: drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program Remove the BOM, the rest of the file is plain ASCII anyway. Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before: drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text and after: drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)